[MacPorts] #52709: GitHub login redirects to main Trac page instead of the page I was on
#52709: GitHub login redirects to main Trac page instead of the page I was on ----------------------------+--------------------- Reporter: ryandesign | Owner: admin@… Type: defect | Status: new Priority: Normal | Milestone: Component: server/hosting | Version: Keywords: | Port: ----------------------------+--------------------- If I use the [/login Login link], and I haven't yet logged in, and I go through the GitHub login process, I'm redirected back to [/ the main Trac page] instead of the page I was on. (You can simulate not having logged in before by using your web browser's private browsing function, which hides your existing login cookies.) -- Ticket URL: <https://trac.macports.org/ticket/52709> MacPorts <https://www.macports.org/> Ports system for OS X
#52709: GitHub login redirects to main Trac page instead of the page I was on -----------------------------+--------------------- Reporter: ryandesign | Owner: admin@… Type: defect | Status: new Priority: Normal | Milestone: Component: server/hosting | Version: Resolution: | Keywords: Port: | -----------------------------+--------------------- Comment (by raimue): Note that using `/login` adds another a redirect to `/github/login` first. I only added that because of [https://github.com/trac-hacks/trac- github/issues/95 trac-github#95]. The link in the navigation points to `/github/login`. I can reproduce this with a browser session that was never logged in. The original URL seems to be lost in trac-github with the redirects to GitHub for authorization and then back to the callback URL. The LoginModule will try to redirect back to the referer, which will probably be empty or the GitHub URL (have not checked). Therefore [https://trac.edgewall.org/browser/branches/1.0-stable/trac/web/auth.py#L253 this redirect] drops the user to the front page without a better target. -- Ticket URL: <https://trac.macports.org/ticket/52709#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts