[MacPorts] #45142: pure-stldict @0.8: new port
#45142: pure-stldict @0.8: new port ------------------------+-------------------------------- Reporter: aggraef@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Keywords: | Port: pure-stldict ------------------------+-------------------------------- This Pure module is currently missing in MacPorts. It is needed as a dependency for pd-faust. -- Ticket URL: <https://trac.macports.org/ticket/45142> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: Thanks, I've been meaning to get this port added. I disagree with these lines you've added: {{{ # MacPorts wants to override these, but we really need them as they are. build.post_args CXXFLAGS="-g -O2 -std=c++0x -Wall" }}} The reason why the pure portgroup sets CXXFLAGS is to build with the right `-arch` flags. Overriding this would normally mean `-arch` flags would no longer be used. However in this case I see they are still used, because the build also uses the LDFLAGS variable which still contains them. But let's step back and look at the real reason why you added this line. Looks like the pure-stldict Makefile sets CXXFLAGS, and the portgroup is overriding it. Generally, there needs to be a way to build a piece of software with additional CXXFLAGS (and other flags). Up until now, my understanding was that they correct way to do this with pure modules was to just supply `CXXFLAGS=...` as an argument to the `make` command. If that actually overrides the Makefile's CXXFLAGS, what do you suggest instead? Also, I see that the Makefile has a hardcoded reference to `g++` which needs to be changed to `$(CXX)`. -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Comment (by aggraef@…): Yes, the Makefile sets CXXFLAGS, that's not really good practice but it's just the way it is right now. I can fix that (along with the g++ -> $(CXX)) in a future release, but what to do with the current version? The quickest way to make the port work was to just set the build.post_args (rather than patching the Makefile), do you have another suggestion? -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Comment (by aggraef@…): BTW, pure-stllib (ticket #45143) most likely has the same issues. -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Comment (by ryandesign@…): For now we could have the portfile append to configure.cxx_flags, since the portgroup includes that variable. -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: r125710 -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Comment (by aggraef@…): Replying to [comment:3 aggraef@…]:
BTW, pure-stllib (ticket #45143) most likely has the same issues.
No, actually it doesn't. I'll correct that portfile. -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#45142: pure-stldict @0.8: new port ---------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: Port: pure-stldict | ---------------------------+-------------------------- Comment (by aggraef@…): Replying to [comment:4 ryandesign@…]:
For now we could have the portfile append to `configure.cxxflags`, since the portgroup includes that variable.
Ok, thanks. I've fixed the Makefile in the Pure repo already, so this will become unnecessary in the next release. -- Ticket URL: <https://trac.macports.org/ticket/45142#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts