#52511: mc: subshell not worling with /bin/sh -----------------------+------------------- Reporter: sierkb@… | Owner: mk@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: mc | -----------------------+------------------- Changes (by mf2k@…): * cc: mk@… (removed) * keywords: subshell not worling with /bin/sh => * owner: macports-tickets@… => mk@… -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:1> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52511: mc: subshell not working with /bin/sh -----------------------+------------------ Reporter: sierkb@… | Owner: mk@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: mc | -----------------------+------------------ Description changed by larryv@…: Old description:

After upgrading from macOS 10.11 to 10.12 and reinstalling MacPorts with all the ports, I run into the following problem:

When trying a {{{ $ sudo mc Password: }}} on macOS 10.12.0 (Sierra), mc throws a {{{ common.c: unimplemented subshell type 1 read (subshell_pty...): No such file or directory (2) }}}

Searching for this error, I've stumbled over similar problems/bugs relating mc on FreeBSD:

mc [https://www.midnight-commander.org/ticket/3658 Ticket #3658 (new defect) - Subshell not working with Bourne shell /bin/sh (not bash)] and FreeBSD [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208391 Bug 208391 - misc/mc SUBSHELL not working with /bin/sh]

I've never had this problem before on macOS 10.11.x and older, and I guess, something might have changed on 10.12 relating /bin/sh resp. the shell environment. Please fix here on MacPorts with a patch or upstream, so that mc is usable again with subshell on macOS 10.12.x (Sierra).

New description: After upgrading from macOS 10.11 to 10.12 and reinstalling MacPorts with all the ports, I run into the following problem: When trying a {{{ $ sudo mc Password: }}} on macOS 10.12.0 (Sierra), mc throws a {{{ common.c: unimplemented subshell type 1 read (subshell_pty...): No such file or directory (2) }}} Searching for this error, I've stumbled over similar problems/bugs relating mc on FreeBSD: - mc: [https://www.midnight-commander.org/ticket/3658 Ticket #3658 (new defect) - Subshell not working with Bourne shell /bin/sh (not bash)] - FreeBSD: [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208391 Bug 208391 - misc/mc SUBSHELL not working with /bin/sh] I've never had this problem before on macOS 10.11.x and older, and I guess, something might have changed on 10.12 relating /bin/sh resp. the shell environment. Please fix here on MacPorts with a patch or upstream, so that mc is usable again with subshell on macOS 10.12.x (Sierra). -- -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:3> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52511: mc: subshell not working with /bin/sh -----------------------+------------------ Reporter: sierkb@… | Owner: mk@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: mc | -----------------------+------------------ Comment (by mk@…): Well, I can't test on 10.12.0, unfortunately... Not sure what to do about this for now. Re bash: OK, I see, you've globally set that for your user account. -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:5> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52511: mc: subshell not working with /bin/sh -----------------------+------------------ Reporter: sierkb@… | Owner: mkae Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: mc | -----------------------+------------------ Comment (by sierkb): Replying to [comment:6 mkae]:

Perhaps you can contact upstream, sierkb, and report back if there is something new happening.

Done. See [https://www.midnight-commander.org/ticket/3658#comment:5 mc ticket 3658: Subshell not working with Bourne shell /bin/sh (not bash), comment 5] and first reaction in [https://www.midnight- commander.org/ticket/3658#comment:6 comment 6].

Alternatively I could try adapt the patch for MacPorts and attach it to this ticket so that you can test it locally on your system.

OK. Yes, please.

Once your Sierra gets an update

Apple has released 10.12.1 update yesterday, I've installed it: {{{ $ sw_vers ProductName: Mac OS X ProductVersion: 10.12.1 BuildVersion: 16B2555 }}}

you can check again with the unpatched version of mc in order to verify what I am seeing here on my Beta.

OK… Result: {{{ $ sudo mc common.c: unimplemented subshell type 1 read (subshell_pty...): No such file or directory (2) }}} Same error as before. I have no clue, why your 10.12.1 beta seems to work at that point, but not the stable 10.12.1 release on my installation. And no clue, why I've had no problem at the very same point with 10.11.x and lower but since 10.12.x. What has changed in 10.12.x concerning shell/subshell that effects this? -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X

#52511: mc: subshell not working with /bin/sh -----------------------+---------------------- Reporter: sierkb@… | Owner: mkae Type: defect | Status: accepted Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: mc | -----------------------+---------------------- Changes (by mkae): * status: new => accepted -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X

#52511: mc: subshell not working with /bin/sh -----------------------+-------------------- Reporter: sierkb@… | Owner: mkae Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: mc | -----------------------+-------------------- Comment (by sierkb): Replying to [comment:10 mkae]:

So, I've built and ran a patched {{{mc}}} on Sierra (and for reference also on Mavericks) w/o seeing the above issue anymore.

Done in r154272! (Let's hope that the buildbots will be fine with it!)

OK. Thanks a lot. It works for me. But this tiny patch used by you has a disadvantage (delay of 5 or 10 seconds), as also mentioned in [https://www .midnight-commander.org/ticket/3658#comment:1 mc Ticket #3658 comment 1]: ''The attached patch allows mc to start without error. However, there is a 5 second delay when it starts. When trying to use the subshell, it simply shows a blank terminal, at which point any key press returns you to the normal mc file layout screen.'' I guess, there seems to be a better and more sophisticated upstream patch around (hint: this mc upstream comment [https://www.midnight- commander.org/ticket/3689#comment:11 mc doesn't recognize shell (e.g., /bin/sh) as bash when it is a link to bash binary, comment 11]), which avoids such delays and other things: '''[https://www.midnight-commander.org/ticket/3692 mc Ticket #3692 More sophisticated shell type detection method]''' Maybe prefer this more sophisticated mc ticket 3692 patch over the quick fix mc ticket 3658 patch used by you? [[br]]

Yet, I don't know what to make of the [https://www.midnight- commander.org/ticket/3658#comment:6 patch source's comment:6]...

See below.

Well, it's solved for MacPorts now.

See above.

If they don't want to commit this patch they'll surely figure out another solution.

Maybe they prefer this mentioned [https://www.midnight- commander.org/ticket/3692 mc Ticket #3692 More sophisticated shell type detection method] (which is targeted: ''Future Releases'', that's why I asked them to ship it more early rather than in any so far unnamend future release)? -- Ticket URL: <https://trac.macports.org/ticket/52511#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X