[MacPorts] #52324: syncthing @0.14.7 new port
#52324: syncthing @0.14.7 new port ---------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: syncthing ---------------------------------+-------------------------------- More information about the project can be found at https://syncthing.net and https://github.com/syncthing/syncthing. I'm volunteering to be the maintainer of this port. As this is my first port built via Go and I'm not an expert, I'm not sure if I did it in a completely idiomatic way. Please let me know if this can be improved. I intend to introduce subports that are built from this same source for the discovery server, relay server, etc. but I want get this basic package committed first. Note that until it reaches 1.0, new versions of Syncthing (0.x) change the protocol in a non-backwards compatible way, which forces all devices to be upgrade at the same. This usually happens every few months (0.14 is from July, 0.13 from May). Because such an upgrade can be really disruptive, I would some feedback about how we handle 0.15 when it comes out: 1. should `syncthing` be upgraded to 0.15 which will break synchronization until users upgrade all their other devices? 2. should `syncthing` be upgraded to 0.15 and 0.14 becomes `syncthing-0.14`, so users can downgrade after an upgrade? (probably the port should have a note to warn users in this case) 3. should this port be named `syncthing-0.14` from the start so the user has to explicitly install `syncthing-0.15` to upgrade? (note that old versions are abandoned, they won't have security fixes — when a new version comes out we could make a new revision of the old port to tell users of that fact) 4. some other alternative that I am missing? As a user, I would probably vote for 3 to minimize any disruption of my workflow. It takes a few days/weeks for all the popular Syncthing apps (especially mobile clients) to get updated. -- Ticket URL: <https://trac.macports.org/ticket/52324> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by mf2k@…): Duplicate of #48905. Significant progress was made before the submitter stopped responding. Please check the comments in that ticket. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:1> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): I have tweaked the Portfile a bit. In case I should submit to #48905 instead, please let me know. I believe this Portfile addresses all the comments made on that ticket. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:3> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): On a second though, I'm removing `README.md` for the launchd plist since it contains instructions for copying the `syncthing` binary that do not apply to this port. The port notes will function as a replacement. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:4> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by ryandesign@…): `build.cmd` should reference `${prefix}/bin/go` instead of `go`, just in case the user has modified their `binpath`. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:6> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): Right, an oversight of my part. Submitted new Portfile. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:7> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): I'm a have user of this program and due to their past history in breaking backwards compatibility, I really would like to discuss the possibility of naming this port `syncthing-0.14` so the user has to explicitly upgrade to a new "major" version (it's 0.x is because the protocol is not set in stone yet). An automatic upgrade would make the device not able to synchronize until all other devices are upgraded at the same time, rendering the program effectively useless. Speaking as a user of this port, I would find that very disruptive/annoying. Once a new "major" version is out we could release a new revision for the previous version with a note saying that users should install the new port if they want new updates. I don't think it's necessary to maintain more than the newest and the previous version. Older versions can be just made obsolete. A similar situation happens with `gnupg21` port due to being non-backwards compatible. -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:8> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by larryv@…): This would be fine. We have several series of ports that do the same thing (clang, gcc, python, etc.). -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:9> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): Great. Should I submit a new patch or are you fine with changing the name yourself? -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:10> MacPorts <https://www.macports.org/> Ports system for macOS
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): I have renamed the port to `syncthing-0.14`. Is there anything else preventing this from getting merged? -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:11> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52324: syncthing @0.14.7 new port ----------------------------------+---------------------- Reporter: leonardo.schenkel@… | Owner: mk@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: syncthing | ----------------------------------+---------------------- Changes (by mk@…): * status: new => assigned * owner: macports-tickets@… => mk@… Comment: No, actually, committed in r153618. (I've added myself for now as co-maintainer.) -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:12> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------- Reporter: leonardo.schenkel@… | Owner: mk@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: Port: syncthing | ----------------------------------+-------------------- Changes (by mk@…): * status: assigned => closed * resolution: => fixed -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:13> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52324: syncthing @0.14.7 new port ----------------------------------+-------------------- Reporter: leonardo.schenkel@… | Owner: mk@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: syncthing | ----------------------------------+-------------------- Changes (by mk@…): * version: 2.3.4 => -- Ticket URL: <https://trac.macports.org/ticket/52324#comment:14> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
participants (1)
-
MacPorts