[MacPorts] #14503: upgrade libtool to 1.5.26, add patch to avoid -flat_namespace
#14503: upgrade libtool to 1.5.26, add patch to avoid -flat_namespace -------------------------------------------------------------+-------------- Reporter: ricci@macports.org | Owner: boeyms@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace | -------------------------------------------------------------+-------------- libtool 1.5.26 plus the attached patch will properly avoid the use of -flat_namespace when 'MACOSX_DEPLOYMENT_TARGET' is not set. The use of flat_namespace on 10.5.2 appears to be harmful (lots of linking problems) -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/14503> MacPorts </projects/macports> Ports system for Mac OS
#14503: libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace ---------------------------------+------------------------------------------ Reporter: ricci@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace ---------------------------------+------------------------------------------ Changes (by ryandesign@macports.org): * cc: boeyms@macports.org (added) * owner: boeyms@macports.org => ryandesign@macports.org * summary: upgrade libtool to 1.5.26, add patch to avoid -flat_namespace => libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace * milestone: => Port Updates Comment: Upgrading libtool to 1.5.26 is also supposed to fix #13182 on Leopard so I think I'll apply these patches. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/14503#comment:1> MacPorts </projects/macports> Ports system for Mac OS
#14503: libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace ---------------------------------+------------------------------------------ Reporter: ricci@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace ---------------------------------+------------------------------------------ Comment (by ryandesign@macports.org): 1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of `-flat_namespace` when `MACOSX_DEPLOYMENT_TARGET` is not set. The use of `flat_namespace` on 10.5.2 appears to be harmful". MacPorts always sets `MACOSX_DEPLOYMENT_TARGET`, so how will avoiding `-flat_namespace` when `MACOSX_DEPLOYMENT_TARGET` is ''not'' set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with `-flat_namespace`. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/14503#comment:2> MacPorts </projects/macports> Ports system for Mac OS
#14503: libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace ---------------------------------+------------------------------------------ Reporter: ricci@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace ---------------------------------+------------------------------------------ Comment (by ricci@macports.org): Replying to [comment:2 ryandesign@macports.org]:
1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of `-flat_namespace` when `MACOSX_DEPLOYMENT_TARGET` is not set. The use of `flat_namespace` on 10.5.2 appears to be harmful". MacPorts always sets `MACOSX_DEPLOYMENT_TARGET`, so how will avoiding `-flat_namespace` when `MACOSX_DEPLOYMENT_TARGET` is ''not'' set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with `-flat_namespace`.
I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released. The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/14503#comment:3> MacPorts </projects/macports> Ports system for Mac OS
#14503: libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace ---------------------------------+------------------------------------------ Reporter: ricci@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: libtool MACOSX_DEPLOYMENT_TARGET flat_namespace ---------------------------------+------------------------------------------ Changes (by ryandesign@macports.org): * status: new => closed * resolution: => fixed Comment: Replying to [comment:3 ricci@macports.org]:
I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released.
Oh yes, you're right, that's not in MacPorts 1.6.0; that's only in trunk. I keep forgetting that.
The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly.
Thanks. If the libtool maintainer says so, that's good enough for me. I committed it in r35661. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/14503#comment:4> MacPorts </projects/macports> Ports system for Mac OS
participants (1)
-
MacPorts