[MacPorts] #44273: audacious-plugins: notes format fix.
#44273: audacious-plugins: notes format fix. ---------------------------------+-------------------------------- Reporter: ionic@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: audacious-plugins ---------------------------------+-------------------------------- This changes the `notes` block to `notes-append` and uses a `TCL block` instead of a literal string. No functional change. -- Ticket URL: <https://trac.macports.org/ticket/44273> MacPorts <http://www.macports.org/> Ports system for OS X
#44273: audacious-plugins: notes format fix. --------------------------------+--------------------------------- Reporter: ionic@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: audacious-plugins | --------------------------------+--------------------------------- Comment (by ryandesign@…): I would be inclined to remove the asterisks because they give the impression that someone thinks these notes are more important than any other port's notes. I would then also be inclined to allow MacPorts to wrap the text to the user's terminal width rather than putting each sentence on a new line. What do you think about my alternative patch? -- Ticket URL: <https://trac.macports.org/ticket/44273#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44273: audacious-plugins: notes format fix. --------------------------------+--------------------------------- Reporter: ionic@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: audacious-plugins | --------------------------------+--------------------------------- Changes (by toby@…): * status: new => closed * resolution: => fixed Comment: Too late, committed r121791 -- Ticket URL: <https://trac.macports.org/ticket/44273#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#44273: audacious-plugins: notes format fix. --------------------------------+--------------------------------- Reporter: ionic@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: audacious-plugins | --------------------------------+--------------------------------- Comment (by ionic@…): Replying to [comment:1 ryandesign@…]:
I would be inclined to remove the asterisks because they give the impression that someone thinks these notes are more important than any other port's notes.
I've seen other ports doing this sort of thing, that's why I did it initially. I'm totally fine with dropping the asterisks. [[BR]][[BR]]
I would then also be inclined to allow MacPorts to wrap the text to the user's terminal width rather than putting each sentence on a new line.
That's a bad idea, to my mind. That makes it difficult/uncomfortable to read on terminals with a big width. That's also the reason why website layouts normally don't use the full width but a specific percentage of it -- to increase readability. (Any port with notes I've so far seen shows this behavior, too.) [[BR]][[BR]]
What do you think about my alternative patch?
Go ahead and remove the asterisks, I'm doing that locally too. If you don't feel like pushing such a trivial change, I'll include it next time there is more to do, maintenance-wise. -- Ticket URL: <https://trac.macports.org/ticket/44273#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts