#52493: yubico-piv-tool: new port ----------------------------------+--------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer haspatch Port: yubico-piv-tool | ----------------------------------+--------------------------------- Comment (by leonardo.schenkel@…): The license was wrong, I have fixed it. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:1> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Old description:

This port installs command line tools to manage the PIV applet which is included in the YubiKey NEO. It also contains a PKCS#11 module to make the keys/certs usable by PKCS#11-aware programs (plus I'm including the necessary glue to make it auto-discoverable by p11-kit).

I'm volunteering to maintain this port.

Unfortunately the latest official release has some annoying bugs (including a build bug that prevents it from being built properly) that were later fixed in Git, so for now I'm building the a hash from master (and calling it 1.2.5-pre) but I intend to stop tracking master and stick to official releases once 1.2.5 is out.

New description: This port installs command line tools to manage the PIV applet which is included in the YubiKey NEO. It also contains a PKCS!#11 module to make the keys/certs usable by PKCS!#11-aware programs (plus I'm including the necessary glue to make it auto-discoverable by p11-kit). I'm volunteering to maintain this port. Unfortunately the latest official release has some annoying bugs (including a build bug that prevents it from being built properly) that were later fixed in Git, so for now I'm building the a hash from master (and calling it 1.2.5-pre) but I intend to stop tracking master and stick to official releases once 1.2.5 is out. -- Comment (by ryandesign@…): The openssl dependency should be written `path:lib/libssl.dylib:openssl` There should not be a `/` in `${destroot}/${p11kit_module_configs} ` New port submissions should be made by submitting the Portfile, not a diff that creates the Portfile. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:3> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by cal@…): Replying to [comment:4 leonardo.schenkel@…]:

1. When a Portfile has additional files, should it be submitted as a .patch or something else (.zip)?

If it's only a file or two, just attach them directly.

2. Since the port is linking to `libcrypto` why am I checking for `libssl`?

`path:lib/libssl.dylib:openssl` allows `libressl` to satisfy the dependency; it doesn't matter whether you use `libssl` or `libcrypto` here, since both are provided by the same port. You can change it, but AFAIK we have all openssl dependencies written in this way.

3. Why are you suggesting to change the dependency from `lib:...` to `path:...`?

See above. Thanks for doing this. Ping me if this gets stuck for too long. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:5> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by larryv@…): Replying to [comment:6 leonardo.schenkel@…]:

I understand that both OpenSSL and LibreSSL provide the library. What I don't understand is that I was asked to change from:

`lib:libcrypto:openssl`

which as I understand means "install OpenSSL if libcrypto.dylib is not available" to:

`path:lib/libssl.dylib:openssl`

which not only should be equivalent to the above in a more verbose syntax

[https://guide.macports.org/chunked/reference.dependencies.html#reference.dep... They are not equivalent]. `lib:libcrypto:openssl` would also find `/usr/lib/libcrypto.dylib`, which is not acceptable. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:7> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): Could I get another review for this submission, please? -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:9> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): Thank you, but I think the dependency should have been `path:lib/libcrypto.dylib:openssl` instead. I have asked multiple times for clarification regarding why I was previously asked to change from `libcrypto` to `libssl` (the `lib:` to `path:` part is clear now) but there was no reply. I don't understand why the port should look for the existence of a library that it does not link against. Could you please shed some light on the matter, cal@macports.org? -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:11> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): OK, then. I thought the whole point was to check for the needed library, and if it is not present then specify which port provides it so it gets installed. I just find it strange to check for a file that's not required by the port. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:13> MacPorts <https://www.macports.org/> Ports system for the Mac operating system

#52493: yubico-piv-tool: new port ----------------------------------+-------------------------------- Reporter: leonardo.schenkel@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: yubico-piv-tool | ----------------------------------+-------------------------------- Comment (by leonardo.schenkel@…): Sure, but in this case you are choosing one among the multiple files that you depend and are provided by the dependency. But here we're choosing one of the files the port *does not* need that happens to be provided by a dependency that provides files that the port does need. That simply seems wrong to me. Imagine that tomorrow there's a new crypto library that provides a compatible implementation of `libcrypto` (but not SSL/TLS); if that port was installed it would satisfy the requirement for this port, but this Portfile would still install `openssl` even though that's unnecessary (and would cause a conflict). Anyway, I'm not asking for any change to be made. I'm just asking/discussing for the intellectual exercise (and I like to understand the reasoning behind certain decisions). I just think that if you need to pick an arbitrary file to declare a dependency on, it makes more sense to pick a file that you actually depend on than one random one that you don't. But it's a matter of opinion, I guess. -- Ticket URL: <https://trac.macports.org/ticket/52493#comment:15> MacPorts <https://www.macports.org/> Ports system for the Mac operating system