[MacPorts] #47942: xraylib @3.1.0_0: libxrl.dylib is built with flat namespace on Yosemite
#47942: xraylib @3.1.0_0: libxrl.dylib is built with flat namespace on Yosemite --------------------------+------------------------------ Reporter: ryandesign@… | Owner: Tom.Schoonjans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Keywords: haspatch | Port: xraylib --------------------------+------------------------------ xraylib's libxrl.dylib is improperly built with the flat namespace instead of the two-level namespace on Yosemite. This can cause problems. The attached patch fixes this, the same way we've been fixing it in other ports. It's a libtool bug that was fixed after Yosemite's release; xraylib's configure script was evidently built with a version of libtool older than that. Before patch: {{{ $ otool -hv /opt/local/lib/libxrl.dylib /opt/local/lib/libxrl.dylib: Mach header magic cputype cpusubtype caps filetype ncmds sizeofcmds flags MH_MAGIC_64 X86_64 ALL 0x00 DYLIB 14 1624 DYLDLINK NO_REEXPORTED_DYLIBS }}} After patch: {{{ $ otool -hv /opt/local/lib/libxrl.dylib /opt/local/lib/libxrl.dylib: Mach header magic cputype cpusubtype caps filetype ncmds sizeofcmds flags MH_MAGIC_64 X86_64 ALL 0x00 DYLIB 14 1624 NOUNDEFS DYLDLINK TWOLEVEL NO_REEXPORTED_DYLIBS }}} May I commit? -- Ticket URL: <https://trac.macports.org/ticket/47942> MacPorts <https://www.macports.org/> Ports system for OS X
#47942: xraylib @3.1.0_0: libxrl.dylib is built with flat namespace on Yosemite ---------------------------+------------------------------ Reporter: ryandesign@… | Owner: Tom.Schoonjans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: | Keywords: haspatch Port: xraylib | ---------------------------+------------------------------ Comment (by Tom.Schoonjans@…): Sure go ahead Exactly what problems could arise on yosemite because of this? -- Ticket URL: <https://trac.macports.org/ticket/47942#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47942: xraylib @3.1.0_0: libxrl.dylib is built with flat namespace on Yosemite ---------------------------+------------------------------ Reporter: ryandesign@… | Owner: Tom.Schoonjans@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.99 Resolution: fixed | Keywords: haspatch Port: xraylib | ---------------------------+------------------------------ Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Committed in r137061. [http://lists.gnu.org/archive/html/libtool- patches/2014-09/msg00001.html Larry says it can cause runtime crashes]. The code was meant to use the flat namespace only on the ancient Mac OS X 10.0, 10.1, and 10.2, but because of the way the OS version check was written, it would also be applied on OS X 10.10 and later. The patch fixes that, and was already accepted by the libtool developers; xraylib just hasn't been repackaged with a fixed version of libtool yet. -- Ticket URL: <https://trac.macports.org/ticket/47942#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts