[MacPorts] #41140: valgrind @3.9.0 fails to build on OS X 10.6.8
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 ------------------------+-------------------------------- Reporter: mopihopi@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: valgrind ------------------------+-------------------------------- valgrind @3.9.0 fails to build on OS X 10.6.8: {{{ $ sudo port upgrade valgrind ---> Computing dependencies for valgrind ---> Fetching archive for valgrind ---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://packages.macports.org/valgrind ---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/valgrind ---> Attempting to fetch valgrind-3.9.0_0.darwin_10.x86_64.tbz2 from http://lil.fr.packages.macports.org/valgrind ---> Fetching distfiles for valgrind ---> Verifying checksums for valgrind ---> Extracting valgrind ---> Applying patches to valgrind ---> Configuring valgrind ---> Building valgrind Error: org.macports.build for port valgrind returned: command execution failed Please see the log file for port valgrind for details: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_devel_valgrind/valgrind/main.log Error: Unable to upgrade port: 1 To report a bug, follow the instructions in the guide: http://guide.macports.org/#project.tickets }}} -- Ticket URL: <https://trac.macports.org/ticket/41140> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Changes (by ryandesign@…): * cc: raimue@… (removed) * owner: macports-tickets@… => raimue@… -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by raimue@…): I guess from the build error this would also fail outside of MacPorts. Please report this problem [http://valgrind.org upstream]. Furthermore, Mac OS X 10.6 Snow Leopard is a system with legacy support only in MacPorts. I would happily accept a patch for the valgrind port that fixes this problem, but I won't work on it myself (as I also don't have an installation of this OS release anymore). -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by florian@…): I attached a workaround. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by raimue@…): Your workaround seems a bit crude and would probably not be accepted upstream. Judging from what you did, I created an untested patch which is supposed to be more correct. Can you please test the attached patch on Snow Leopard? -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by florian@…): Actually my proposed patch just reinstates the conditions in syswrap- darwin.c of version 3.8.1. The #if DARWIN_VERS >= DARWIN_10_7 [...] #endif was absent there. So we don't know whether this is an upstream glitch or intention. From the comments in syswrap-darwin.c I would judge the former. Your patch (which works fine as well) will probably be the desired upstream solution. Pls go ahead and commit. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by mopihopi@…): 10.6 actually does have `psynch_mutexwait`, `psynch_mutexdrop`, `psynch_cvbroad`, `psynch_cvsignal`, `psynch_cvwait`, `psynch_rw_rdlock`, `psynch_rw_wrlock`, and `psynch_rw_unlock`. However `psynch_cvclrprepost` was added in 10.7. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by florian@…): Well then again it would be better to have an intermediate solution. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by mopihopi@…): The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by egall@…): Replying to [comment:13 mopihopi@…]:
The patch in the valgrind bug report https://bugs.kde.org/show_bug.cgi?id=327745 fixes the issue. I re-attached it here for easier review. Could someone commit it please? (I am running into this issue, as well, which is preventing me from testing one of my other Portfiles that I am developing...)
-- Ticket URL: <https://trac.macports.org/ticket/41140#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: valgrind | -------------------------+---------------------- Changes (by raimue@…): * status: new => closed * resolution: => fixed Comment: Committed in r117639. -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X
#41140: valgrind @3.9.0 fails to build on OS X 10.6.8 -------------------------+---------------------- Reporter: mopihopi@… | Owner: raimue@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: valgrind | -------------------------+---------------------- Comment (by egall@…): Replying to [comment:17 raimue@…]:
Committed in r117639.
Just confirming that that worked for me, thanks! -- Ticket URL: <https://trac.macports.org/ticket/41140#comment:18> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts