[MacPorts] #44649: mpv portfile does not parse
#44649: mpv portfile does not parse --------------------------+--------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Keywords: | Port: mpv --------------------------+--------------------- On Mac OS X 10.4: {{{ Can't map the URL 'file://.' to a port description file ("expected boolean value but got "${os.major} == 10 && ${os.minor} >= 3""). }}} -- Ticket URL: <https://trac.macports.org/ticket/44649> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+--------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: mpv | ---------------------------+--------------------- Comment (by ryandesign@…): This seems to fix it: {{{ Index: Portfile =================================================================== --- Portfile (revision 123795) +++ Portfile (working copy) @@ -112,7 +112,7 @@ " # VDA (video hardware acceleration, mostly H264) is only supported on 10.6.3+ - if {${os.major} > 10 || {${os.major} == 10 && ${os.minor} >= 3}} { + if {${os.major} > 10 || (${os.major} == 10 && ${os.minor} >= 3)} { configure.args-delete --disable-vda-hwaccel \ --disable-vda-gl configure.args-append --enable-vda-hwaccel \ }}} -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+--------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: mpv | ---------------------------+--------------------- Comment (by larryv@…): Strictly speaking, the grouping isn’t necessary at all, since Tcl uses C-esque operator precedence (logical-AND binds more tightly than logical- OR). I suppose it does have some readability value. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+--------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: mpv | ---------------------------+--------------------- Comment (by ionic@…): Isn't TCL fun. Yes, I prefer grouping for readability/understandability. Feel free to push, Ryan. May I ask how you got that? Neither portindex nor port itself complained with my original code. On the other hand, are you sure this 10.4 box uses latest base? ${os.minor} was introduced only recently with 2.3.0 IIRC. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Changes (by ryandesign@…): * keywords: => haspatch * status: new => closed * resolution: => fixed Comment: Replying to [comment:3 ionic@…]:
Isn't TCL fun.
Quite!
Yes, I prefer grouping for readability/understandability.
Feel free to push, Ryan.
r123883
May I ask how you got that? Neither `portindex` nor `port` itself complained with my original code.
I just updated my ports tree with "`sudo port -v sync`" as usual and noticed the parse failure in the `portindex` output, then went to investigate. Are you saying you tested on 10.6 or earlier and didn't see this error?
On the other hand, are you sure this 10.4 box uses latest base? `${os.minor}` was introduced only recently with 2.3.0 IIRC.
Yes, it's using 2.3.1. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by larryv@…): Replying to [comment:4 ryandesign@…]:
Yes, it's using 2.3.1.
Is this related to Tcl version? Doesn’t 2.3.1 bundle Tcl 8.5? -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by ryandesign@…): Yes, MacPorts 2.3 and up bundle Tcl 8.5 so MacPorts is now using the same version of Tcl on all versions of OS X. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by larryv@…): Given the unified Tcl, I guess I’m not understanding why this would fail on Tiger but not on more recent OSes. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by ionic@…): Maybe due to short circuit evaluation. I have only tested on 10.9, which falls into the first branch and doesn't check the second one. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by larryv@…): That sounds right. I was thinking that later Tcl started accepting braces for grouping, or something. -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#44649: mpv portfile does not parse ---------------------------+---------------------- Reporter: ryandesign@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: fixed | Keywords: haspatch Port: mpv | ---------------------------+---------------------- Comment (by ionic@…): From MacPort's tclsh: {{{ % if {"a" eq "a" || {"a" eq "b"}} { puts foo } else { puts bar } foo 0 % if {{"a" eq "a"} || {"a" eq "b"}} { puts foo } else { puts bar } expected boolean value but got ""a" eq "a"" }}} -- Ticket URL: <https://trac.macports.org/ticket/44649#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts