[MacPorts] #29090: Portfile submission: PyFITS
#29090: Portfile submission: PyFITS ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: ---------------------------------------+------------------------------------ Attached is a Portfile for PyFITS, a Python interface to FITS formatted file. http://www.stsci.edu/resources/software_hardware/pyfits Sébastien -- Ticket URL: <https://trac.macports.org/ticket/29090> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Changes (by ryandesign@…): * port: => py27-pyfits -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: Thanks. Do you mind if we change the port name to py27-fits? -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by ryandesign@…): Here's my proposed portfile, in which I: * change name to py27-fits * adjust whitespace and add modeline * drop revision line * remove md5 checksum * fix numpy dependency (this is py27-fits so it needs to depend on py27-numpy not py26-numpy) * depends_lib-append instead of depends_lib to avoid overwriting the portgroup's dependencies * added supported_archs noarch -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by ryandesign@…): Replying to [comment:3 ryandesign@…]:
* added supported_archs noarch
This turns out to have been false, and I've removed it from the attachment. See also #26839 for the request for the py26 version of the port. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by ryandesign@…): I've attached a new proposal which incorporates ideas from #26839 to fix the livecheck. I also deleted the build.target which seems unnecessary. #26839 lists distribute as a dependency, but I'm not sure it's actually needed; confirmation from someone more familiar with python would be appreciated. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by sebastien.maret@…): Replying to [comment:3 ryandesign@…]:
Here's my proposed portfile, in which I:
* change name to py27-fits
Thanks for the revision. It looks good to me, except perhaps for the name change. The name of this package is PyFITS, not FITS. The name py27-fits may confuse users that are searching for pyfits, because "port search pyfits" won't find it. Unless there is a MacPort policy that encourage developer dropping the "py" in Python packages, I would rather have the package named py27-pyfits. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by sebastien.maret@…): Replying to [comment:5 ryandesign@…]:
#26839 lists distribute as a dependency, but I'm not sure it's actually needed; confirmation from someone more familiar with python would be appreciated.
I don't think that distribute is needed. I don't have it installed and pyfits compiles and run fine for me. Also this module is not imported anywhere in pyfits; it uses the standard distutils module. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ---------------------------------------+------------------------------------ Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: py27-pyfits ---------------------------------------+------------------------------------ Comment(by marshall.perrin@…): I strongly concur with Sebastian that the name of this package should remain 'pyfits' since that is the official name of the package that every user will expect to find it under. And yes, distribute is not required. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29090: py27-pyfits: Portfile submission ----------------------------------------+----------------------------------- Reporter: sebastien.maret@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: py27-pyfits | ----------------------------------------+----------------------------------- Changes (by ryandesign@…): * status: assigned => closed * cc: robitaille@… (added) * resolution: => fixed Comment: Very good, I've added py27-pyfits in r79102. Sorry for the delay; thanks to Thomas Robitaille for reminding me to address this ticket. -- Ticket URL: <https://trac.macports.org/ticket/29090#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts