#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ram@…): If the patchfiles are going to be committed to SVN you don't need to include the checksums in the Portfile, these are only needed if they are downloaded. However, if I remove the checksums for the patchfiles then this still fails for me, on El Capitan, with the following: {{{ :info:build /usr/bin/python ./framecpp_sample.py :info:build Traceback (most recent call last): :info:build File "./framecpp_sample.py", line 6, in <module> :info:build import frameCPP :info:build File "/opt/local/var/macports/build /_Users_ram_macports_ports_science_ldas-tools/ldas-tools/work/ldas- tools-2.4.2/libraries/framecpp/src/OOInterface/frameCPP.py", line 33, in <module> :info:build _frameCPP = swig_import_helper() :info:build File "/opt/local/var/macports/build /_Users_ram_macports_ports_science_ldas-tools/ldas-tools/work/ldas- tools-2.4.2/libraries/framecpp/src/OOInterface/frameCPP.py", line 25, in swig_import_helper :info:build import _frameCPP :info:build ImportError: dlopen(/opt/local/var/macports/build /_Users_ram_macports_ports_science_ldas-tools/ldas-tools/work/ldas- tools-2.4.2/libraries/framecpp/src/OOInterface/.libs/_frameCPP.so, 2): Library not loaded: /opt/local/lib/libframecpp.6.dylib :info:build Referenced from: /opt/local/var/macports/build /_Users_ram_macports_ports_science_ldas-tools/ldas-tools/work/ldas- tools-2.4.2/libraries/framecpp/src/OOInterface/.libs/_frameCPP.so :info:build Reason: image not found }}} I'll attach the full build log. I think the problem here is that the system python is being used, so the appropriate libraries can't be found. I think you need to specify that the MacPorts python should be used (using `configure.python`), otherwise it's just going to use whatever `python` is in the environment. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ram@…): Replying to [comment:4 ed.maros@…]:

What would be most ideal is if I could fully qualify the path to the version specific python executable. Ideas on how to do this?

Would the following work? {{{ configure.python ${prefix}/bin/python${v} }}}

Also, when I submit the patch, should it replace the current Portfile patch or be relative to the existing patch.

Relative to what's in SVN would probably make more sense. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ed.maros@…): I have uploaded a new patch for the Portfile to address the ElCapitan issue. I have added a single line which directs the build to use the MacPorts version specific Python interpreter as directed by the variant option. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ed.maros@…): Replying to [comment:8 ram@…]:

Replying to [comment:7 ed.maros@…]:

...

I have uploaded a new patch for the Portfile to address the ElCapitan issue. I have added a single line which directs the build to use the MacPorts version specific Python interpreter as directed by the variant option.

The checksums for the patches are still present and there is no python interpreter specified, are you sure this is the new patch? Sorry. I was working on too many systems. I have uploaded the modified patch. It still has the checksums of the patches because I was unable to do a port install without them. Perhaps I do not have my system configured properly for testing purposes. My model for testing is that I have the files in a local directory and do 'sudo port install'. Is this 'forcing' me into having to 'download' the patches (which I accomplish by copying them to the appropriate distfiles location)?

-- Ticket URL: <https://trac.macports.org/ticket/48991#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ram@…): Replying to [comment:10 ram@…]:

I have a test build going now and I'll report back on whether that builds or not once the test has completed.

The build completed successfully. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ed.maros@…): New version has been uploaded with consistent white spaces, no checksums for patches and removal of unneeded openssl library dependency. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ed.maros@…): Replying to [comment:14 ram@…]:

Are you sure that `ssl` is unneeded as `libframecpp8.dylib`, for example, is linked against `libcrypto` from `openssl`:

{{{ $ otool -L libframecpp8.dylib libframecpp8.dylib: /opt/local/lib/libframecpp8.4.dylib (compatibility version 5.0.0, current version 5.0.0) /opt/local/lib/libframecpp7.2.dylib (compatibility version 3.0.0, current version 3.1.0) /opt/local/lib/libframecpp6.5.dylib (compatibility version 6.0.0, current version 6.0.0) /opt/local/lib/libframecpp4.5.dylib (compatibility version 6.0.0, current version 6.0.0) /opt/local/lib/libframecpp3.3.dylib (compatibility version 5.0.0, current version 5.0.0) /opt/local/lib/libframecppcmn.4.dylib (compatibility version 7.0.0, current version 7.0.0) /opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0) /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1225.1.1) /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.1.0) $ port provides /opt/local/lib/libcrypto.1.0.0.dylib /opt/local/lib/libcrypto.1.0.0.dylib is provided by: openssl $ }}}

Good catch. I will put it back. Question is system version vs MacPorts version. -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Comment (by ed.maros@…): New version with the proper ssl library reference -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:17> MacPorts <https://www.macports.org/> Ports system for OS X

#48991: ldas-tools @2.4.2 Updated for latest release of software -------------------------+--------------------------------- Reporter: ed.maros@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: ldas-tools | -------------------------+--------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r141069. I removed the quotes around `${prefix}/bin/python${v}` because they are not needed. I made the python27 variant the default only if the other python variant was not already selected. See PortfileRecipes#default_variants. I changed "configure.args-strsed s/--disable-python/--enable-python/" which had already been in the portfile to "configure.args-replace --disable-python --enable-python" -- Ticket URL: <https://trac.macports.org/ticket/48991#comment:19> MacPorts <https://www.macports.org/> Ports system for OS X