#47934: libvpx should be in depends_build not depends_lib -------------------------------------------------+------------------------- Reporter: ryandesign@… | Owner: Type: defect | ryandesign@… Priority: Normal | Status: new Component: ports | Milestone: Resolution: | Version: 2.3.3 Port: avidemux, ffmpeg, ffmpeg-devel, | Keywords: gd2, gstreamer010-gst-plugins-bad, gstreamer1 | -gst-plugins-good | -------------------------------------------------+------------------------- Comment (by ryandesign@…): Replying to [comment:1 devans@…]:

I don't know about "should" but I think, theoretically, you're right about making libvpx or any lib that produces only a static library a build dependency. The lib dependency is not "wrong" per se as it doesn't break the port but could be viewed as overkill.

What I meant was that making it a library dependency causes libvpx to be installed on users' systems when it doesn't need to be. There is no benefit to it being there, for users installing these ports from binaries. I was just hesitating because every port depending on libvpx does it by library dependency, and I wanted to make sure there wasn't some reason why this was needed in this case. But I don't think there is. -- Ticket URL: <https://trac.macports.org/ticket/47934#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X

#47934: libvpx should be in depends_build not depends_lib -------------------------------------------------+------------------------- Reporter: ryandesign@… | Owner: Type: defect | ryandesign@… Priority: Normal | Status: new Component: ports | Milestone: Resolution: | Version: 2.3.3 Port: avidemux, ffmpeg, ffmpeg-devel, | Keywords: gd2, gstreamer010-gst-plugins-bad, gstreamer1 | -gst-plugins-good | -------------------------------------------------+------------------------- Comment (by devans@…): ffmpeg, ffmpeg-devel fixed in r137058 [[BR]] gstreamer010-gst-plugins-bad fixed in r137067 [[BR]] gstreamer1-gst-plugins-good fixed in r137068 -- Ticket URL: <https://trac.macports.org/ticket/47934#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X

#47934: libvpx should be in depends_build not depends_lib -------------------------------------------------+------------------------- Reporter: ryandesign@… | Owner: Type: defect | ryandesign@… Priority: Normal | Status: closed Component: ports | Milestone: Resolution: fixed | Version: 2.3.3 Port: avidemux, ffmpeg, ffmpeg-devel, | Keywords: gd2, gstreamer010-gst-plugins-bad, gstreamer1 | -gst-plugins-good | -------------------------------------------------+------------------------- Comment (by dstrubbe@…): I'm don't think this is a good idea for gd2, because it recommends linking libvpx according to its config binary: {{{ gdlib-config --libs -lgd -ljpeg -lz -L/opt/local/lib -lpng16 -L/opt/local/lib -lfreetype -L/opt/local/lib -lfontconfig -lfontconfig -L/opt/local/lib -lXpm -L/opt/local/lib -lvpx -L/opt/local/lib -ltiff -liconv }}} Everything else in this list is depends_lib for gd2. As a result, a code which naturally uses the output of this command in a configure script to decide how to link will fail if libvpx is no longer installed. On the other hand, the depends_lib port:expat does not seem to be dynamically linked into any library or executable from gd2, so I wonder if it really needs to be depends_lib. -- Ticket URL: <https://trac.macports.org/ticket/47934#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X