[MacPorts] #48293: cppcheck using cxx11 PortGroup
#48293: cppcheck using cxx11 PortGroup ---------------------------------+-------------------------------- Reporter: xythobuz@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: cppcheck ---------------------------------+-------------------------------- As discussed in Ticket #48247, here is the patch from ionic to start using the cxx11 PortGroup in cppcheck. -- Ticket URL: <https://trac.macports.org/ticket/48293> MacPorts <https://www.macports.org/> Ports system for OS X
#48293: cppcheck using cxx11 PortGroup --------------------------+--------------------------------- Reporter: xythobuz@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer haspatch Port: cppcheck | --------------------------+--------------------------------- Comment (by ionic@…): Okay... thanks for your response, but why did you open another ticket? Do you want to resolve the user's problem some other way? The `cxx PortGroup` will only terminate if it detects `libstdc++`, but not actually help in making the port installable. If you don't plan on ripping all the C++11 stuff out, this ticket is really a duplicate of #48247 and should be closed as that. -- Ticket URL: <https://trac.macports.org/ticket/48293#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48293: cppcheck using cxx11 PortGroup --------------------------+--------------------------------- Reporter: xythobuz@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer haspatch Port: cppcheck | --------------------------+--------------------------------- Comment (by xythobuz@…): I don't have any commit rights, so I thought this is the correct way of getting this change committed? It won't change the functionality, but enhances readability of the PortFile. Also, I was told to create a separate Ticket for each change I want to commit for the port I'm maintaining. -- Ticket URL: <https://trac.macports.org/ticket/48293#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48293: cppcheck using cxx11 PortGroup --------------------------+--------------------------------- Reporter: xythobuz@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: duplicate | Keywords: maintainer haspatch Port: cppcheck | --------------------------+--------------------------------- Changes (by ionic@…): * status: new => closed * resolution: => duplicate Comment: No, not in this case. I've given you a patch, which you as a maintainer can either accept or deny in the other ticket. If you accept, I commit, otherwise I don't (and you'll have to come up with something else.) A new ticket is appropriate if you had a patch for something else entirely - like updating the port to a newer version, adding a variant or changing dependencies or even whitespace changes that don't influence the user's initially reported failure. Marking as dup of #48247 and committing the patch there. -- Ticket URL: <https://trac.macports.org/ticket/48293#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts