[MacPorts] #16282: emacs 22.2: bad use of chown in destroot stage
#16282: emacs 22.2: bad use of chown in destroot stage ---------------------------------+------------------------------------------ Reporter: vinc17@macports.org | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Keywords: | ---------------------------------+------------------------------------------ I get the following errors: {{{ ---> Staging emacs into destroot [...] for dir in /opt/local/var/macports/build/_Users_vinc17_software_dports_editors_emacs/work/emacs-22.2/etc /opt/local/var/macports/build/_Users_vinc17_software_dports_editors_emacs/work/emacs-22.2/lisp ; do \ dest=$1 ; shift ; \ [ -d ${dir} ] \ && [ `(cd ${dir} && /bin/pwd)` != `(cd ${dest} && /bin/pwd)` ] \ && (echo "Copying ${dir} to ${dest}..." ; \ (cd ${dir}; tar -chf - . ) \ | (cd ${dest}; umask 022; \ tar -xvf - && cat > /dev/null) || exit 1; \ find ${dest} -exec chown ${LOGNAME:-$USERNAME} {} ';' ;\ for subdir in `find ${dest} -type d ! -name RCS ! -name CVS -print` ; do \ chmod a+rx ${subdir} ; \ rm -rf ${subdir}/RCS ; \ rm -rf ${subdir}/CVS ; \ rm -f ${subdir}/.cvsignore ; \ rm -f ${subdir}/.arch-inventory ; \ rm -f ${subdir}/\#* ; \ rm -f ${subdir}/.\#* ; \ rm -f ${subdir}/*~ ; \ rm -f ${subdir}/*.orig ; \ rm -f ${subdir}/[mM]akefile* ; \ rm -f ${subdir}/ChangeLog* ; \ rm -f ${subdir}/dired.todo ; \ done) ; \ done Copying /opt/local/var/macports/build/_Users_vinc17_software_dports_editors_emacs/work/emacs-22.2/etc to /opt/local/var/macports/build/_Users_vinc17_software_dports_editors_emacs/work/destroot/opt/local/share/emacs/22.2/etc... ./ ./BABYL ./calccard.ps ./calccard.tex [...] ./yow.lines usage: chown [-fhv] [-R [-H | -L | -P]] owner[:group] file ... chown [-fhv] [-R [-H | -L | -P]] :group file ... usage: chown [-fhv] [-R [-H | -L | -P]] owner[:group] file ... chown [-fhv] [-R [-H | -L | -P]] :group file ... [...] }}} Here "sudo env | grep NAME" gives: {{{ LOGNAME=root USERNAME=vinc17 }}} I suppose that the problem is that MacPorts undefines both LOGNAME and USERNAME. -- Ticket URL: <http://trac.macports.org/ticket/16282> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16282: emacs 22.2: bad use of chown in destroot stage ----------------------------------+----------------------------------------- Reporter: vinc17@macports.org | Owner: darren.bane@gmail.com Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ----------------------------------+----------------------------------------- Changes (by vinc17@macports.org): * owner: macports-tickets@lists.macosforge.org => darren.bane@gmail.com Comment: Forgot to assign to maintainer... -- Ticket URL: <http://trac.macports.org/ticket/16282#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16282: emacs 22.2: bad use of chown in destroot stage ----------------------------------+----------------------------------------- Reporter: vinc17@macports.org | Owner: darren.bane@gmail.com Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ----------------------------------+----------------------------------------- Comment (by vinc17@macports.org): Replying to [ticket:16282 vinc17@macports.org]:
I suppose that the problem is that MacPorts undefines both LOGNAME and USERNAME.
Indeed, if I insert {{{ echo "chown '$${LOGNAME:-$$USERNAME}' ..." ; \ }}} before the "find $${dest} -exec chown", I get: {{{ chown '' ... }}} I think that a fix would be to remove all these unnecessary chown's. Or MacPorts base should be fixed to keep LOGNAME set to a valid value (I wonder if unsetting it is allowed by POSIX). -- Ticket URL: <http://trac.macports.org/ticket/16282#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16282: emacs 22.2: bad use of chown in destroot stage ----------------------------------+----------------------------------------- Reporter: vinc17@macports.org | Owner: darren.bane@gmail.com Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ----------------------------------+----------------------------------------- Comment (by raimue@macports.org): Can someone explain why emacs wants to change the owner at all? Would it be a problem if it is owned by root? -- Ticket URL: <http://trac.macports.org/ticket/16282#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16282: emacs 22.2: bad use of chown in destroot stage ----------------------------------+----------------------------------------- Reporter: vinc17@macports.org | Owner: darren.bane@gmail.com Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ----------------------------------+----------------------------------------- Comment (by darren.bane@gmail.com): I agree that the chowns are unnecessary, and have uploaded patches to remove them. Can someone with commit privs do the honours please? Also, the other patches in editors/emacs/files are no longer used and can be removed. -- Ticket URL: <http://trac.macports.org/ticket/16282#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16282: emacs 22.2: bad use of chown in destroot stage ----------------------------------+----------------------------------------- Reporter: vinc17@macports.org | Owner: darren.bane@gmail.com Type: defect | Status: closed Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: ----------------------------------+----------------------------------------- Changes (by febeling@macports.org): * status: new => closed * resolution: => fixed Comment: I did so in r39221 and close the ticket. -- Ticket URL: <http://trac.macports.org/ticket/16282#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts