[MacPorts] #16491: base/src/port/port.tcl should quote homepage when opening it
#16491: base/src/port/port.tcl should quote homepage when opening it ------------------------------------------+--------------------------------- Reporter: blb@macports.org | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: MacPorts base bugs Component: base | Version: 1.7.0 Keywords: port command homepage gohome | Port: ------------------------------------------+--------------------------------- In the code for handling the gohome command, the $homepage variable is not quoted when passed to the shell, which causes issues when a character handled by the shell is present in the homepage. To see this, try {{{port gohome xdvipdfmx}}} and note that the page loaded has everything from the & to the end stripped. To see a more catastrophic error, try {{{port gohome libksba}}} (at least until that port's homepage is corrected). -- Ticket URL: <http://trac.macports.org/ticket/16491> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16491: base/src/port/port.tcl should quote homepage when opening it -------------------------------+-------------------------------------------- Reporter: blb@macports.org | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: MacPorts base bugs Component: base | Version: 1.7.0 Resolution: | Keywords: port command homepage gohome Port: | -------------------------------+-------------------------------------------- Changes (by raimue@macports.org): * cc: raimue@macports.org (added) Comment: Shouldn't that be single quotes? With double quotes, there is still replacement for $HOME or other environment variables happening. Unlikely that it appears in an homepage URL, but let's fix it completely. -- Ticket URL: <http://trac.macports.org/ticket/16491#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16491: base/src/port/port.tcl should quote homepage when opening it -------------------------------+-------------------------------------------- Reporter: blb@macports.org | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: MacPorts base bugs Component: base | Version: 1.7.0 Resolution: | Keywords: port command homepage gohome Port: | -------------------------------+-------------------------------------------- Comment(by blb@macports.org): Hmm, yeah, not sure why I went with double, even with singles not having to be escaped. Patch updated. -- Ticket URL: <http://trac.macports.org/ticket/16491#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16491: base/src/port/port.tcl should quote homepage when opening it -------------------------------+-------------------------------------------- Reporter: blb@macports.org | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: closed Priority: Normal | Milestone: MacPorts base bugs Component: base | Version: 1.7.0 Resolution: fixed | Keywords: port command homepage gohome Port: | -------------------------------+-------------------------------------------- Changes (by raimue@macports.org): * status: new => closed * resolution: => fixed Comment: Committed your patch in r40414. -- Ticket URL: <http://trac.macports.org/ticket/16491#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16491: base/src/port/port.tcl should quote homepage when opening it -------------------------------+-------------------------------------------- Reporter: blb@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: MacPorts 1.7.0 Component: base | Version: 1.7.0 Resolution: fixed | Keywords: port command homepage gohome Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * milestone: MacPorts Future => MacPorts 1.7.0 -- Ticket URL: <http://trac.macports.org/ticket/16491#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts