[MacPorts] #51610: xdrfile @ 1.1.4 new port
#51610: xdrfile @ 1.1.4 new port ------------------------------+-------------------------------- Reporter: giovanni.bussi@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: xdrfile ------------------------------+-------------------------------- I would like to contribute a port for this BSD library: http://www.gromacs.org/Developer_Zone/Programming_Guide/XTC_Library -- Ticket URL: <https://trac.macports.org/ticket/51610> MacPorts <https://www.macports.org/> Ports system for OS X
#51610: xdrfile @ 1.1.4 new port -------------------------------+-------------------------------- Reporter: giovanni.bussi@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: xdrfile | -------------------------------+-------------------------------- Comment (by mf2k@…): Comments: - In general, we do not set {{{distfiles}}} directly, it is best practice to set ${distname} and ${extract.suffix} separately. - Considering adding {{{openmaintainer}}} since you are not a committer. - Is there a non-FTP master_sites location? - Have you tested this when building {{{+universal}}}? You are overriding the {{{configure.args}}} which are set by the [browser:trunk/dports/_resources/port1.0/group/muniversal-1.0.tcl muniversal PortGroup]. -- Ticket URL: <https://trac.macports.org/ticket/51610#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51610: xdrfile @ 1.1.4 new port -------------------------------+-------------------------------- Reporter: giovanni.bussi@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: Port: xdrfile | -------------------------------+-------------------------------- Comment (by giovanni.bussi@…): Thanks for the hints! - I removed {{{distfiles}}} as suggested. - I added {{{openmaintainer}}} as suggested. - I replaced {{{configure.args}}} with {{{configure.args-append}}} to avoid overriding other flags. Actually, I also realised that the port compiles properly with +universal even without including the muniversal portgroup. I thus removed it. About a non-FTP {{{master_sites}}} location, I am not aware of it. I hope the revised port can be considered for inclusion. Thanks again! Giovanni -- Ticket URL: <https://trac.macports.org/ticket/51610#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51610: xdrfile @ 1.1.4 new port -------------------------------+-------------------------------- Reporter: giovanni.bussi@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: Port: xdrfile | -------------------------------+-------------------------------- Changes (by raimue@…): * status: new => closed * resolution: => fixed Comment: Thank you for the submission. Committed in r149826. -- Ticket URL: <https://trac.macports.org/ticket/51610#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts