[MacPorts] #41174: nip2 7.26.3_1 fails under Mavericks
#41174: nip2 7.26.3_1 fails under Mavericks ----------------------------+-------------------------------- Reporter: mschamschula@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: ----------------------------+-------------------------------- I get the following error in building nip2 7.26.3_1 under Mavericks: {{{ /usr/bin/clang -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -I/opt/local/include/graphviz -I/opt/local/include -D_REENTRANT -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -D_THREAD_SAFE -D_REENTRANT -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include -I/opt/local/include /gdk-pixbuf-2.0 -I/opt/local/include/libpng15 -I/opt/local/include -I/opt/local/include/libxml2 -I/opt/local/include -I/opt/local/include/ImageMagick-6 -I/opt/local/include/orc-0.4 -I/opt/local/include -I/opt/local/include/OpenEXR -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/libpng15 -I/opt/local/include -DG_DISABLE_CAST_CHECKS -I/opt/local/include -pipe -Os -arch x86_64 -MT nip2-iimageview.o -MD -MP -MF .deps/nip2-iimageview.Tpo -c -o nip2-iimageview.o `test -f 'iimageview.c' || echo './'`iimageview.c graphwindow.c:263:38: error: too few arguments to function call, expected 2, have 1 graphwindow->graph = agread( of->fp ); ~~~~~~ ^ /opt/local/include/graphviz/cgraph.h:268:1: note: 'agread' declared here extern Agraph_t *agread(void *chan, Agdisc_t * disc); ^ 1 error generated. make[3]: *** [nip2-graphwindow.o] Error 1 }}} Full main.log attached -- Ticket URL: <https://trac.macports.org/ticket/41174> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 7.26.3_1 fails under Mavericks -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => jcupitt@… * keywords: => mavericks * port: => nip2 -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 7.26.3_1 fails under Mavericks -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by mschamschula@…): I updated the Portfile to the current version of nip2: 7.36.4. This builds fine, even under Mavericks. -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 7.26.3_1 fails under Mavericks -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by mschamschula@…): I have updated nip2 to @7.38.1. Also fixed depends_lib from goffice to goffice08, as office now requires gtk+3. -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by khindenburg@…): Thanks I updated to 7.38.3 and it builds on mavericks - why change goffice to goffice08? -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by jcupitt@…): goffice is gtk+3 and nip2 is still a gtk+2 program. goffice08 is the last goffice that builds with gtk+2. nip2 will be moving to gtk+3, but not for another year or so. -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by khindenburg@…): It builds/installs but it won't run Program received signal SIGABRT, Aborted. 0x00007fff97f2b866 in __pthread_kill () -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by khindenburg@…): It works if you run from source folder ./src/nip2 but not from a 'make install' -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by khindenburg@…): The issue appears to be this memccpy in src/tools: {{{ /* Strip underscores (they mark mnemonics). Can't use$ * strrcpy(), we have overlapping blocks.$ */$ im_strncpy( value, toolitem->label, MAX_NAME );$ for( i = 0; value[i]; i++ )$ if( value[i] == '_' )$ memccpy( value + i, value + i + 1,$ 0, MAX_NAME - i ); }}} -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Comment (by jcupitt@…): Thanks for finding this khindenburg. I've made a 7.38.4 which incorporates a version of your patch: https://github.com/jcupitt/nip2/commit/74454e179b6bf961eaa697ae691cd66b4347a... I was stupidly using memccpy() on overlapping memory areas, which is undefined. #44090 has a portfile update which switches to this version. I think this closes both these tickets. -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#41174: nip2 update to 7.38.3 - fixes build on mavericks ( 7.26.3_1 fails under Mavericks) -----------------------------+----------------------- Reporter: mschamschula@… | Owner: jcupitt@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: duplicate | Keywords: mavericks Port: nip2 | -----------------------------+----------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) * status: new => closed * resolution: => duplicate Comment: Superseded by #44090. -- Ticket URL: <https://trac.macports.org/ticket/41174#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts