[MacPorts] #20664: Enable smartcard support to rdesktop
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- I would like to suggest adding a variant to the Portfile enabling the smartcard forwarding supported by rdesktop 1.6. I tested by adding the following, which seems to work: variant smartcard description {enables smartcard forwarding} { configure.args-append --enable-smartcard } There is a requirement for PCSC-lite 1.2.9 or later noted in rdesktop release notes. The pcscd distributed with Mac OS 1.5.7 reports: PCSC Framework version 1.4.0. I have tested this by modifying the Portfile and I can successfully forward the smartcard to a Win2003 server. -- Ticket URL: <http://trac.macports.org/ticket/20664> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Comment(by cshbell@…): Looks good. Portfile attached above. Maintainer noses@noses.com dropped, per his request. Please merge into trunk. -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Comment(by macsforever2000@…): Replying to [comment:1 cshbell@…]:
Looks good. Portfile attached above. Maintainer noses@noses.com dropped, per his request.
Please merge into trunk.
A couple of observations: * A [http://guide.macports.org/#development.patches.portfile unified diff] is preferred. * Your portfile is revision 1 of version 1.6.0. But the current version is already at revision 2. * The first line of your portfile is invalid. * Your email address needs to be obfuscated. -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Comment(by cshbell@…): Diff attached. -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Comment(by thomas.akesson@…): What is the process for getting the diff merged into trunk? -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Comment(by blb@…): That diff definitely doesn't seem to be against the Portfile in the repository, everything is colon-delimited in the patched Portfile but definitely not in the [browser:trunk/dports/net/rdesktop/Portfile real one]. -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop ----------------------------------------+----------------------------------- Reporter: thomas.akesson@… | Owner: macsforever2000@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Keywords: | Port: rdesktop ----------------------------------------+----------------------------------- Changes (by macsforever2000@…): * owner: macports-tickets@… => macsforever2000@… * status: new => assigned -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#20664: Enable smartcard support to rdesktop -----------------------------------------+---------------------------------- Reporter: thomas.akesson@… | Owner: macsforever2000@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Resolution: fixed | Keywords: Port: rdesktop | -----------------------------------------+---------------------------------- Changes (by macsforever2000@…): * status: assigned => closed * resolution: => fixed Comment: Next time, please supply a [http://guide.macports.org/#development.patches.portfile proper patch] based on the latest version of the portfile from the repository. Updated in r57543. -- Ticket URL: <http://trac.macports.org/ticket/20664#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts