[MacPorts] #32764: virtualbox version modification throwing off downstream software
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: -----------------------------+---------------------------------------------- $ VBoxManage --version 4.1.8_MacPortsr75467 I think this causes vagrant to fail https://github.com/mitchellh/vagrant/issues/619 Why 4.1.8_MacPortsr75467? Why not 4.1.8_r75467 or 4.1.8_r75467_MacPorts which would be more compatible with existing string parsing? -- Ticket URL: <https://trac.macports.org/ticket/32764> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: -----------------------------+---------------------------------------------- Comment(by bm55b@…): This is the version that comes out of the DMG installed VirtualBox for reference $ VBoxManage --version 4.1.8r75467 So I'd amend my bug report and say... Why not 4.1.8r75467 or 4.1.8r75467_MacPorts which would be more compatible with existing string parsing? -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: -----------------------------+---------------------------------------------- Comment(by bm55b@…): Having format issues.. Copy/paste loses carriage returns! Macports... {{{ $ VBoxManage --version 4.1.8_MacPortsr75467 }}} virtualbox.org {{{ $ VBoxManage --version 4.1.8r75467 }}} suggest {{{ $ VBoxManage --version 4.1.8r75467_MacPorts }}} -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: virtualbox -----------------------------+---------------------------------------------- Changes (by ryandesign@…): * port: => virtualbox Old description:
$ VBoxManage --version 4.1.8_MacPortsr75467
I think this causes vagrant to fail
Why 4.1.8_MacPortsr75467? Why not 4.1.8_r75467 or 4.1.8_r75467_MacPorts which would be more compatible with existing string parsing?
New description: {{{ $ VBoxManage --version 4.1.8_MacPortsr75467 }}} I think this causes vagrant to fail https://github.com/mitchellh/vagrant/issues/619 Why 4.1.8_MacPortsr75467? Why not 4.1.8_r75467 or 4.1.8_r75467_MacPorts which would be more compatible with existing string parsing? -- -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: virtualbox -----------------------------+---------------------------------------------- Comment(by ryandesign@…): Yes please remember to use WikiFormatting. -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: virtualbox -----------------------------+---------------------------------------------- Comment(by ryandesign@…): All we are doing is changing VBOX_BUILD_PUBLISHER from "_OSE" to "_MacPorts". The VirtualBox developers request that packagers like MacPorts do this. I am currently unable to find the URL where they say this, but I have seen it before. Perhaps vagrant needs to update its code to accommodate this recommended practice. -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software -----------------------------+---------------------------------------------- Reporter: bm55b@… | Owner: royliu@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Keywords: | Port: virtualbox -----------------------------+---------------------------------------------- Changes (by royliu@…): * owner: macports-tickets@… => royliu@… Comment: Yes, we are complying to VirtualBox developers' wishes by appending "_MacPorts" to the version, but I think that bm55b is right by pointing out that `4.1.8r75467_MacPorts` is more appropriate. Once I patch VirtualBox appropriately, I'll also generate a pull request for Vagrant on GitHub (I live in both worlds). -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#32764: virtualbox version modification throwing off downstream software ------------------------------+--------------------------------------------- Reporter: bm55b@… | Owner: royliu@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.0.3 Resolution: wontfix | Keywords: Port: virtualbox | ------------------------------+--------------------------------------------- Changes (by royliu@…): * status: new => closed * resolution: => wontfix Comment: On second thought, I don't think a fix is feasible. Performing a `grep` over `VBOX_VERSION_STRING` (which is `4.1.8_MacPorts` in our case) yields: {{{ ... src/VBox/Additions/solaris/DRM/vboxvideo_drm.c: DEVICE_DESC_DRV " " VBOX_VERSION_STRING "r" VBOXSOLQUOTE(VBOX_SVN_REV), src/VBox/Additions/solaris/Installer/vboxguest.pkginfo:VERSION="@VBOX_VERSION_STRING@,REV=r@VBOX_SVN_REV@.@VBOX_VERSION_REVSTAMP@" src/VBox/Additions/solaris/Installer/vboxguest.pkginfo:SUNW_PRODVERS="@VBOX_VERSION_STRING@" src/VBox/Additions/solaris/Makefile.kmk: -e "s/@VBOX_VERSION_STRING@/$(VBOX_VERSION_STRING)/g" \ src/VBox/Additions/solaris/SharedFolders/vboxfs_vfs.c: DEVICE_DESC " " VBOX_VERSION_STRING "r" VBOXSOLQUOTE(VBOX_SVN_REV), src/VBox/Additions/solaris/Virtio/Makefile.kmk:virtionet_DEFS = VBOX_WITH_HGCM VBOX_SVN_REV=$(VBOX_SVN_REV) VBOX_VERSION_STRING=\"$(VBOX_VERSION_STRING)\" src/VBox/Additions/solaris/Virtio/VirtioNet-solaris.c: DEVICE_DESC_DRV " " VBOX_VERSION_STRING "r" RT_XSTR(VBOX_SVN_REV), ... }}} This tells me that the VirtualBox developers actually intend for the SVN revision to immediately come after `VBOX_VERSION_STRING`. Consequently, I'm going to close the issue and try to solve this issue in Vagrant itself. -- Ticket URL: <https://trac.macports.org/ticket/32764#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts