#37129: pango 1.30.1 coretext bug ------------------------+-------------------------- Reporter: markau0@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: pango | ------------------------+-------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * port: => pango Old description:

pango 1.30.1 has a coretext bug that can cause the errors below.

The current MacPorts pango version seems to be 1.30.1 which probably contains the coretext bug.

---------------------------------------------------------------------

GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)'

GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)'

Pango-CRITICAL **: _pango_cairo_font_map_get_renderer: assertion `PANGO_IS_CAIRO_FONT_MAP (fontmap)' failed

-----------------------------------------------------------------------------------

pango 1.30.0 doesn't have the coretext bug and is ok.

The bug was introduced with pango 1.30.1 and fixed in a later version

Introduced bug from pango 1.30.1 ChangeLog

------------------------------------------------------------------------------

commit f5135453d26e68f9f2fbe8f0ddb01e437df41384 Author: Kristian Rietveld <kris@loopnest.org> Date: Mon Jun 4 20:27:01 2012 +0200

Bug 673497 - corefont fallback not always working

The fallback failed when a "small caps" font was requested. This commit improves the fallback support. When the first fallback, trying Sans with the same style fails, we reset the variant, weight and stretch to default values and try again. With Sans we should always be able to adhere to the requested style.

Last but not least, output a sensible error message if all fallbacks fail instead of simply crashing on a NULL pointer somewhere.

-------------------------------------------------------------------------------------

and fixed in the pango later than 1.30.1 ChangeLog

-------------------------------------------------------------------------------------

commit 70a85d441d973883af4afb57599bc570eeea4c83 Author: Kristian Rietveld <kris@loopnest.org> Date: Tue Jun 5 22:34:59 2012 +0200

coretext: don't insert item in the hash if it originated from the hash

Oversight in my fallback fix, this resulted in things being wrongly destroyed due to unrefs. Oops.

pango/pangocoretext-fontmap.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)

New description: pango 1.30.1 has a coretext bug that can cause the errors below. The current MacPorts pango version seems to be 1.30.1 which probably contains the coretext bug. {{{ GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' Pango-CRITICAL **: _pango_cairo_font_map_get_renderer: assertion `PANGO_IS_CAIRO_FONT_MAP (fontmap)' failed }}} pango 1.30.0 doesn't have the coretext bug and is ok. The bug was introduced with pango 1.30.1 and fixed in a later version Introduced bug from pango 1.30.1 ChangeLog {{{ commit f5135453d26e68f9f2fbe8f0ddb01e437df41384 Author: Kristian Rietveld <kris@loopnest.org> Date: Mon Jun 4 20:27:01 2012 +0200 Bug 673497 - corefont fallback not always working The fallback failed when a "small caps" font was requested. This commit improves the fallback support. When the first fallback, trying Sans with the same style fails, we reset the variant, weight and stretch to default values and try again. With Sans we should always be able to adhere to the requested style. Last but not least, output a sensible error message if all fallbacks fail instead of simply crashing on a NULL pointer somewhere. }}} and fixed in the pango later than 1.30.1 ChangeLog {{{ commit 70a85d441d973883af4afb57599bc570eeea4c83 Author: Kristian Rietveld <kris@loopnest.org> Date: Tue Jun 5 22:34:59 2012 +0200 coretext: don't insert item in the hash if it originated from the hash Oversight in my fallback fix, this resulted in things being wrongly destroyed due to unrefs. Oops. pango/pangocoretext-fontmap.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) }}} -- Comment: Thanks for the report! Of course I want to [ticket:36810 update pango to 1.32] but that is delayed for now, so I'll see if I can cherry-pick this fix until then. -- Ticket URL: <https://trac.macports.org/ticket/37129#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS