[MacPorts] #35388: arb Patches for Mountain Lion 10.8
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- arb Patches for Mountain Lion 10.8 -- Ticket URL: <https://trac.macports.org/ticket/35388> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by ryandesign@…): You probably shouldn't depend on port:xorg; you should depend on the specific xorg ports that you actually need. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by ryandesign@…): Maybe I should ask: why are you adding the xorg dependency on Mountain Lion only? Is it because Mountain Lion does not include X11 anymore? If so, then I don't think adding additional xorg dependencies is correct. The user could either install the xorg-server port, or install [http://xquartz.macosforge.org/landing/ XQuartz]; either would be fine (just as on previous versions of OS X, the user could use the xorg-server port, XQuartz, or the X11 Apple included). So I don't think we should now force the user to use xorg-server. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by matt.cottrell@…): That's right, I was dealing with Mountain Lion not supplying X11. What is the best way to head off novice users installing arb on Mountain Lion only to get the "Cannot open display" error the first time they try to run arb? I could add instructions to the port notes directing folks to install xorg-server and quartz-wm or XQuarz, I suppose. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by matt.cottrell@…): Okay, I'll add some notes about installing X11. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by matt.cottrell@…): I should have given this ticket a more informative title. It solves a build error seen with Mountain Lion: {{{ Error: reinplace: sed: RE error: illegal byte sequence Error: org.macports.configure for port arb returned: reinplace sed(1) failed }}} The attached portfile diff solves the problem by eliminating the need to reinplace sed for gsed and using coreutils instead. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 -----------------------------------+---------------------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch | Port: arb -----------------------------------+---------------------------------------- Comment(by matt.cottrell@…): The arb port will not build on Mountain Lion without this Portfile patch, at least not for me. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 ----------------------------------------------+----------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch mountainlion | Port: arb ----------------------------------------------+----------------------------- Changes (by ryandesign@…): * keywords: maintainer haspatch => maintainer haspatch mountainlion Comment: I don't quite understand the patch... what component of coreutils is arb using, and how does that relate to whether you use `sed` or `gsed`? FYI there's nothing wrong with using `reinplace` to change "sed" to "gsed", except that the `sed` that `reinplace` runs needs to know what character encoding the files use. It assumes UTF-8, but at least one of the files you're reinplacing is not UTF-8. So you have to tell it a suitable locale. The locale "C" is ofter suitable, and that is what we have been using in other ports to fix this error: {{{ reinplace locale -C ... }}} -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 ----------------------------------------------+----------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch mountainlion | Port: arb ----------------------------------------------+----------------------------- Comment(by matt.cottrell@…): Revised Portfile.diff using "reinplace -locale C" now builds on Mountain Lion. Note the misplaced "-" in the previous comment, vis-a-vie: {{{ reinplace -locale C ... }}} -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 ----------------------------------------------+----------------------------- Reporter: matt.cottrell@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch mountainlion | Port: arb ----------------------------------------------+----------------------------- Comment(by matt.cottrell@…): Now I'm receiving email from arb users who are experiencing build failures with Mountain Lion. Can I get a thumbs up on my patch and a commit to satisfy them? -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 ----------------------------------------------+----------------------------- Reporter: matt.cottrell@… | Owner: dports@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: maintainer haspatch mountainlion | Port: arb ----------------------------------------------+----------------------------- Changes (by dports@…): * status: new => assigned * owner: macports-tickets@… => dports@… -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35388: arb Patches for Mountain Lion 10.8 ------------------------------------+--------------------------------------- Reporter: matt.cottrell@… | Owner: dports@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: maintainer haspatch mountainlion Port: arb | ------------------------------------+--------------------------------------- Changes (by dports@…): * status: assigned => closed * resolution: => fixed Comment: Thanks, committed in r96547. I left out the revision bump; because the problem was a build error, it shouldn't be necessary to force people who already have the port installed to rebuild. -- Ticket URL: <https://trac.macports.org/ticket/35388#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts