#42333: OpenSSH: update to 6.5 -----------------------+-------------------------------- Reporter: kentas@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: openssh | -----------------------+-------------------------------- Comment (by kentas@…): Replying to [comment:1 cal@…]:

A common oversight when updating OpenSSH are the variants and different patches we provide for OpenSSH, such as the HPN patch. I assume that one probably has not been updated to 6.5 yet?

https://github.com/bdrewery/openssh/commit/7d7e36ee7496a5afbf209d787ae3207b5... -- Ticket URL: <https://trac.macports.org/ticket/42333#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X

#42333: OpenSSH: update to 6.5 -----------------------+-------------------------------- Reporter: kentas@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: openssh | -----------------------+-------------------------------- Comment (by mlindgren@…): The FreeBSD guys use this patch, hopefully it proves useful: http://mirror.shatow.net/freebsd/openssh/openssh-6.5p1-hpnssh14v2.diff.gz -- Ticket URL: <https://trac.macports.org/ticket/42333#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#42333: OpenSSH: update to 6.5 -----------------------+-------------------------------- Reporter: kentas@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: openssh | -----------------------+-------------------------------- Changes (by snc@…): * cc: cal@…, ciserlohn@…, sean@…, dluke@…, snc@… (added) -- Ticket URL: <https://trac.macports.org/ticket/42333#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#42333: OpenSSH: update to 6.5 -----------------------+-------------------------------- Reporter: kentas@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: openssh | -----------------------+-------------------------------- Comment (by raimue@…): Just for the next time, spaces are usually preferred instead of tabs in Portfiles. Mixing them both is bad practice, but that can be corrected easily. The referenced file `openssh-6.5p1-hpnssh14v2.diff.gz` is missing from the tarball. Also, you are changing `UsePrivilegeSeparation sandbox` to `UsePrivilegeSeparation yes`. I guess that would be because of #36291. In such a case I would always appreciate a link to the ticket in the Portfile as otherwise nobody knows why it was done. Finding the cause of the problem would be preferred, but that should be discussed in the other ticket. -- Ticket URL: <https://trac.macports.org/ticket/42333#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X

#42333: OpenSSH: update to 6.5 -----------------------+-------------------------------- Reporter: kentas@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: openssh | -----------------------+-------------------------------- Comment (by mlindgren@…): Replying to [comment:10 raimue@…]:

Just for the next time, spaces are usually preferred instead of tabs in Portfiles. Mixing them both is bad practice, but that can be corrected easily.

The referenced file `openssh-6.5p1-hpnssh14v2.diff.gz` is missing from the tarball.

Also, you are changing `UsePrivilegeSeparation sandbox` to `UsePrivilegeSeparation yes`. I guess that would be because of #36291. In such a case I would always appreciate a link to the ticket in the Portfile as otherwise nobody knows why it was done. Finding the cause of the problem would be preferred, but that should be discussed in the other ticket.

Sorry about the whitespace issue. Yes, I could not get sandboxing to work properly, so I went with PrivilegeSeparation yes as is the default in OpenSSH 6.4. Let me know if I need to make a change before you commit. -- Ticket URL: <https://trac.macports.org/ticket/42333#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X