#13356: XMMS2 Portfile ---------------------------+------------------------------------------------ Reporter: tru@xmms.org | Owner: macports-dev@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.5.2 Resolution: | Keywords: ---------------------------+------------------------------------------------ Changes (by nox@macports.org): * cc: nox@macports.org (added) Comment: Some comments: * {{{$version}}} should really be set to {{{0.4}}}, as it doesn't make any sense to have some joke wandering alone in the version string. * You don't need to explicitely set {{{$revision}}} to {{{0}}}. * Instead of writing custom configure/build/destroot stages, you should rather do {{{ configure.cmd ./waf configure.args --conf-prefix=${prefix} build.cmd ./waf destroot.cmd ./waf destroot.destdir --destdir=${destroot} }}} -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13356#comment:2> MacPorts </projects/macports> Ports system for Mac OS

#13356: XMMS2 Portfile ---------------------------+------------------------------------------------ Reporter: tru@xmms.org | Owner: macports-dev@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.5.2 Resolution: | Keywords: ---------------------------+------------------------------------------------ Comment (by tru@xmms.org): Replying to [comment:2 nox@macports.org]:

Some comments: * {{{$version}}} should really be set to {{{0.4}}}, as it doesn't make any sense to have some joke wandering alone in the version string.

It's actually not a joke. DR = Developer Release, and the names after are in sequential order. Next version will be named 0.4DrL ... something.

* You don't need to explicitely set {{{$revision}}} to {{{0}}}. * Instead of writing custom configure/build/destroot stages, you should rather do {{{ configure.cmd ./waf configure.args --conf-prefix=${prefix}

build.cmd ./waf

destroot.cmd ./waf destroot.destdir --destdir=${destroot} }}}

Thanks for your suggestions, here is the updated portfile: {{{ # $Id$ PortSystem 1.0 name xmms2 version 0.4DrKosmos categories audio maintainers nomaintainer description CrossPlatform Music Multiplexer System homepage http://xmms2.xmms.org/ platforms darwin master_sites http://dfn.dl.sourceforge.net/sourceforge/xmms2/ #xmms2-0.4DrKosmos.tar.bz2 use_bzip2 yes depends_lib port:glib2 port:sqlite3 port:libmad port:libvorbis port:libogg port:boost depends_build port:python24 checksums md5 f363857a77606a2d7d14603ab375f454 long_description Audio player configure.cmd ./waf configure configure.args --conf-prefix=${prefix} --prefix=${prefix} build.cmd ./waf build build.target destroot.cmd ./waf install destroot.args --destdir=${destroot} destroot.target destroot.destdir }}} -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13356#comment:4> MacPorts </projects/macports> Ports system for Mac OS