[MacPorts] #13932: Update InsightToolkit port
#13932: Update InsightToolkit port -----------------------------------+---------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: High | Milestone: Port Submissions Component: ports | Version: 1.6.0 Keywords: Insight Toolkit | -----------------------------------+---------------------------------------- Hi, a while back I submitted a port for inclusion (ticket 12413). Since that time the software has been updated. Here is a working, updated port. From the discussion on port 12413, I have updated the way the cmake build dependency is listed to include the port cmake instead of just requiring the cmake binary. I assume this is the correct way of doing this now that cmake-devel has been removed as a port. The port seems to work correctly on my system. Please let me know if I've missed anything. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: High | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Changes (by raimue@macports.org): * cc: p.schmiedeskamp@auckland.ac.nz, raimue@macports.org (added) Comment: Would have been much better if you would have submitted this in form of a patch. Adding maintainer to CC. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:1> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: High | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by raimue@macports.org): Sorry, please ignore my previous comment. I understood this wrong, this is a submission, not a port update... Why didn't you call the port itk? I don't like case-sensitive port names and they are known to cause trouble. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:2> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: High | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by peter@thoughtspot.net): There is already an unrelated itk port. I followed FreeBSD's port naming convention given that the name itk was taken: http://www.freebsd.org/cgi/cvsweb.cgi/ports/science/InsightToolkit -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:3> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: High | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by peter@thoughtspot.net): Hi again, does this require any further action on my part? Many thanks! -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:4> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Changes (by jmpp@macports.org): * priority: High => Normal Comment: So I see the Portfile in #12413 hasn't been committed. This ticket is for a submission of an updated Portfile with respect to what was submitted there...? If so, this ticket should be closed as invalid and the new Portfile should be added as a new attachment to #12413. What prompted the original poster to open a new ticket? -jmpp -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:5> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by peter@thoughtspot.net): Well, the original ticket hadn't seen any action in quite some time. Given the fact that the original Portfile had not been committed and the software itself has been through a few revisions subsequently, I thought it might be more convenient for the Macports people to have this created as a separate ticket and simply close the old one. If you'd prefer me to generate a patch against the original Portfile in the original ticket, I can do that. Let me know if you need anything from me to move forward. Cheers, Peter -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:6> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by peter@thoughtspot.net): Replying to [comment:5 jmpp@macports.org]:
So I see the Portfile in #12413 hasn't been committed. This ticket is for a submission of an updated Portfile with respect to what was submitted there...? If so, this ticket should be closed as invalid and the new Portfile should be added as a new attachment to #12413. What prompted the original poster to open a new ticket?
-jmpp
Hi, sorry, just wanted to follow up. Would you like some further action on my part? Cheers, Peter -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:7> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Comment (by ryandesign@macports.org): I closed #12413; we'll handle this in this ticket. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:8> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Changes (by ryandesign@macports.org): * owner: macports-tickets@lists.macosforge.org => ryandesign@macports.org -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:9> MacPorts </projects/macports> Ports system for Mac OS
#13932: Update InsightToolkit port ------------------------------------+--------------------------------------- Reporter: peter@thoughtspot.net | Owner: ryandesign@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Insight Toolkit ------------------------------------+--------------------------------------- Changes (by ryandesign@macports.org): * status: new => closed * resolution: => fixed Comment: Thanks for pestering us about this again. Sorry we forgot about the original ticket. I committed the portfile now in r34064 with the following changes: * removed the line "`revision 1`" because the initial revision of a portfile should be 0, which is the default * removed the line "`distfiles ${name}-${version}${extract.suffix}`" because that's also already the default -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13932#comment:10> MacPorts </projects/macports> Ports system for Mac OS
participants (1)
-
MacPorts