[MacPorts] #50616: wannier90 2.0.1 patch for library
#50616: wannier90 2.0.1 patch for library ------------------------+-------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: wannier90 ------------------------+-------------------------------- Patch to make wannier90 work as a library; tested with abinit. One test changed + 2 memory leaks suppressed. -- Ticket URL: <https://trac.macports.org/ticket/50616> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Changes (by ryandesign@…): * keywords: => haspatch * owner: macports-tickets@… => dstrubbe@… * type: update => enhancement * cc: dstrubbe@… (removed) Comment: I assume this changes the files installed by the port. As such, the port's revision must be increased. Is this change from the developers of wannier90, or known to them? If not, please send it to them as well. -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Comment (by cram5431@…): Revision added.[[BR]] Yes, this patch will be sent to wannier90 developers (I'm in touch with them). This happens every release of the w90 library: it has to be adapted to the codes using it. -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Comment (by cram5431@…): To make Abinit work with wannier90-2.0.1, you need:[[BR]] - a patched version of wannier90 (patch previoulsy commited in this ticket)[[BR]] - a patch for ABINIT (enclosed patch-src-10_defs-defs_wannier90.F90.diff file for ABINIT)[[BR]] This works with my version.[[BR]] [[BR]] Future abinit-v8 test suite has been patched to exclude wannier90#11 test when not compiled with libXC. Thanks for the bug report. -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Comment (by dstrubbe@…): Ok, now the wannier90 tests are passed for me. This change is meaningless (only formatting), isn't it? {{{ - if(boltz_dos_adpt_smr.eqv.adpt_smr .and. boltz_dos_adpt_smr_fac==adpt_smr_fac .and. boltz_dos_adpt_smr_max==adpt_smr_max & + if(boltz_dos_adpt_smr.eqv.adpt_smr .and. boltz_dos_adpt_smr_fac==adpt_smr_fac & + .and. boltz_dos_adpt_smr_max==adpt_smr_max & }}} -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Comment (by cram5431@…): Yes and no...[[BR]] For a compilation with gcc --line-length-none, this change is not needed,[[BR]] For a compilation with a computer not allowing more than 132 chars, it is (checked on my El Capitan)... -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#50616: wannier90 2.0.1 patch for library --------------------------+------------------------ Reporter: cram5431@… | Owner: dstrubbe@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: wannier90 | --------------------------+------------------------ Changes (by dstrubbe@…): * status: new => closed * resolution: => fixed Comment: Committed for abinit and wannier90, r146682. -- Ticket URL: <https://trac.macports.org/ticket/50616#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts