[MacPorts] #51056: pure 0.64 update
#51056: pure 0.64 update ---------------------------------+-------------------------------- Reporter: aggraef@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch maintainer | Port: pure ---------------------------------+-------------------------------- Minor update (bump to revision 3) which adds a patch that fixes an issue with Pure running as a VST plug-in. -- Ticket URL: <https://trac.macports.org/ticket/51056> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Changes (by mf2k@…): * owner: macports-tickets@… => ryandesign@… * version: 2.3.4 => * type: update => enhancement -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Changes (by ryandesign@…): * status: new => assigned Comment: Thanks. Your patch also removes the `port:ncurses` dependency, but I think that needs to stay, because pure and libpure.dylib do link with libncurses.dylib. -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Committed without the removal of `port:ncurses` in r148006. -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Comment (by aggraef@…): Replying to [comment:2 ryandesign@…]:
Thanks. Your patch also removes the `port:ncurses` dependency, but I think that needs to stay, because pure and libpure.dylib do link with libncurses.dylib.
ncurses is needed only for readline (which has it as a dependency), so the dependency shouldn't actually be needed. But it doesn't hurt either. -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Comment (by ryandesign@…): pure links with libncurses, therefore it needs the dependency declared. We use the list of declared dependencies to find ports that need to have their revisions increased to rebuild them after a dependency's library version number has been increased. This happened for example when ncurses' library version increased from 5 to 6 in 2015; pure was broken until its revision was increased in r140525, and to remind us that this needs to happen anytime ncurses' library version changes again in the future, I also added the ncurses dependency at that time. If pure linking with libncurses is unnecessary, and only caused by readline, then that would be a bug we should report against readline. I agree that ports that link with readline do also link with ncurses, but I do not know whether that linkage is unnecessary. -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51056: pure 0.64 update --------------------------+--------------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: pure | --------------------------+--------------------------------- Comment (by aggraef@…): Ok, I understand. I don't recall why exactly linking against ncurses is necessary, probably has something to do with the fact that readline can work with a number of different underlying terminal interfaces. Anyway, let's just keep the ncurses dependency then, I don't see this as an issue. -- Ticket URL: <https://trac.macports.org/ticket/51056#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts