[MacPorts] #39635: Patch: add Python dependency and universal variant to botan
#39635: Patch: add Python dependency and universal variant to botan ------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Keywords: haspatch | Port: botan ------------------------+-------------------------------- {{{botan}}}'s configure script is written in Python, so we need an explicit build dependency. On IRC, jmr_mp and neverpanic both suggested adding a hard-coded dependency on {{{python27}}} instead of a set of variants for different possible Python versions. Moreover, since {{{qt4-creator-mac +universal}}} requires {{{botan +universal}}}, here's an attempt to enable a {{{universal}}} variant for {{{botan}}}. -- Ticket URL: <https://trac.macports.org/ticket/39635> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: Patch: add Python dependency and universal variant to botan -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | -------------------------+-------------------------------- Comment (by macports@…): This patch should fix #39451. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: Patch: add Python dependency and universal variant to botan -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | -------------------------+-------------------------------- Comment (by mcalhoun@…): I do not know much about how botan works, but wouldn't disabling optimizations slow it down? {{{ configure.args-append --disable-asm --enable-modules=mp_generic \ --disable-modules=mp_x86_32,mp_x86_64,rdrand }}} The muniversal PortGroup was designed for just this problem.[[BR]] Attached is another possible solution. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: Patch: add Python dependency and universal variant to botan -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | -------------------------+-------------------------------- Comment (by macports@…): Your patch looks good. Disabling inline assembly is not necessary after all. I had stumbled over some suspicious-looking compiler warnings related to inline assembly (''"variable 'r' is uninitialized when used here"''). However, the resulting machine code is indeed correct, so the warnings can be safely ignored. I've updated my patch to include your changes. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | --------------------------+---------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => mww@… * cc: mww@… (removed) * type: update => enhancement -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | --------------------------+---------------------- Comment (by ryandesign@…): Instead of repeated `if` statements, a [https://www.tcl.tk/man/tcl8.4/TclCmd/switch.htm switch statement] would be shorter. Even shorter would be just referencing the merger_configure_args array that you're defining anyway. See the openssl port for an example of how to do this. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | --------------------------+---------------------- Comment (by macports@…): Thanks for the tips! I updated the patch accordingly. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | --------------------------+---------------------- Comment (by macports@…): *bump* -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: haspatch Port: botan | --------------------------+---------------------- Comment (by macports@…): New patch against current Portfile for version 1.10.6 attached. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#39635: botan: add Python dependency and universal variant --------------------------+---------------------- Reporter: macports@… | Owner: mww@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: fixed | Keywords: haspatch Port: botan | --------------------------+---------------------- Changes (by cal@…): * status: new => closed * resolution: => fixed Comment: Oh wow, that took us a while. Anyway, in r125904 and thanks for the patch. -- Ticket URL: <https://trac.macports.org/ticket/39635#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts