#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------------- Reporter: aggraef@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: faust-devel faust2-devel | ---------------------------------------+-------------------------------- Comment (by aggraef@…): Concerning the serialization of the httpd and dynamic subtargets, it just came to me that a custom build command like `make all httpd sound2faust && make dynamic` would probably do the trick. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by aggraef@…): So can someone please commit this? My courses start in two weeks, and I still need to add a port for the FaustLive package. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by ryandesign@…): I am looking into it right now. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by aggraef@…): Replying to [comment:6 ryandesign@…]:

I did not actually encounter a build failure when using parallel building. Did you? If so could you attach the main.log file?

No, I didn't, but I think that in principle it's possible by looking at the Makefile, so I decided to play it safe. The problem is with `make dynamic`. I really think that this should be executed separately after all the other targets, since otherwise it will invoke a submake which will try to build some of the same targets that `make all` and `make httpd` will try to build, too. It's hard to see whether that's actually a problem in practice, however. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by larryv@…): Replying to [comment:7 aggraef@…]:

The problem is with `make dynamic`. I really think that this should be executed separately after all the other targets, since otherwise it will invoke a submake which will try to build some of the same targets that `make all` and `make httpd` will try to build, too. It's hard to see whether that's actually a problem in practice, however.

The correct way to fix this would be to patch the makefile so that the “dynamic” target depends on whichever other targets need to run first. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by larryv@…): Replying to [comment:10 ryandesign@…]:

It doesn't already?

I haven’t looked myself; I’m just assuming that the dependencies aren’t declared properly. Note that GNU Make [http://www.gnu.org/software/make/manual/html_node/Goals.html#Goals processes goals in the order provided on the command line]. Thus, `make A B C` will handle goal “A”, then “B”, then “C”, in turn. I don’t know whether other Make variants behave similarly, but we can easily force GNU Make: {{{ build.type gnu build.targets-append httpd foo bar baz dynamic }}} This would have no parallel build issues and would obviate the need for the `post-build` song and dance. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by larryv@…): Replying to [comment:12 ryandesign@…]:

GNU make is used by default; `build.type gnu` should change nothing.

[[browser:tags/release_2_3_1/base/src/port1.0/portbuild.tcl#L59|Doesn’t look like it is]]. Not in all cases, anyway, although I think on most (all?) systems we support, `make` is GNU Make, so we can assume the use of GNU Make in practice. In any case, simply listing “dynamic” last in `build.targets` is entirely sufficient. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by larryv@…): Replying to [comment:14 aggraef@…]:

I think that GNU make does that, too, but I might be wrong.

Hm. The documentation is admittedly unclear on this, and briefly perusing the GNU Make source code was not enlightening. That said, we could still patch the phony targets to have the desired dependencies. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X

#45241: faust-devel, faust2-devel: update to latest git source ---------------------------------------+-------------------------- Reporter: aggraef@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: faust-devel faust2-devel | ---------------------------------------+-------------------------- Comment (by aggraef@…): Replying to [comment:16 larryv@…]:

I still say that the simplest solution is to patch the targets’ dependencies.

You're right. Simply adding `baz: foo bar` to your example makes sure that GNU make actually waits for `foo` and `bar` to finish before starting `baz`. Sorry, I didn't realize that, otherwise I would have included a corresponding patch for the toplevel Makefile in the first place. Ryan, I think that it makes most sense if I work with upstream in order to get this fixed (along with the other Makefile issues you encountered), and then submit another update request so that we can do without the patches and the `post-build` stuff, as larry suggested. -- Ticket URL: <https://trac.macports.org/ticket/45241#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X