[MacPorts] #27809: openconnect @2.25 updated to @2.26
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: maintainer haspatch | Port: net/openconnect -----------------------------------------------+---------------------------- Here is the list of modifications made to the Portfile:[[BR]] - add ''openmaintainer'' to the maintainers[[BR]] - remove gconf from ''depends_lib'', fix Ticket #27805[[BR]] - replace the ''patch'' to the Makefile with ''reinplace'' macros[[BR]] - openconnect now needs ''build.target'' on OS X as the author added something else (may be support for network-manager in gnome, I am not using gnome on OS X, I will not try to add a gnome variant)[[BR]] - ''livecheck'' actually works -- Ticket URL: <https://trac.macports.org/ticket/27809> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Changes (by macsforever2000@…): * version: 1.9.2 => * port: net/openconnect => openconnect -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Description changed by ryandesign@…: Old description:
Here is the list of modifications made to the Portfile:[[BR]] - add ''openmaintainer'' to the maintainers[[BR]] - remove gconf from ''depends_lib'', fix Ticket #27805[[BR]] - replace the ''patch'' to the Makefile with ''reinplace'' macros[[BR]] - openconnect now needs ''build.target'' on OS X as the author added something else (may be support for network-manager in gnome, I am not using gnome on OS X, I will not try to add a gnome variant)[[BR]] - ''livecheck'' actually works
New description: Here is the list of modifications made to the Portfile: - add ''openmaintainer'' to the maintainers - remove gconf from ''depends_lib'', fix Ticket #27805 - replace the ''patch'' to the Makefile with ''reinplace'' macros - openconnect now needs ''build.target'' on OS X as the author added something else (may be support for network-manager in gnome, I am not using gnome on OS X, I will not try to add a gnome variant) - ''livecheck'' actually works -- -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Comment(by ryandesign@…): Using the MacPorts base patch from #15514, I get this message when building your port with the patch attached to this ticket: {{{ ---> Fetching openconnect ---> Verifying checksum(s) for openconnect ---> Extracting openconnect Warning: reinplace s|@OPTFLAGS@|-O2| didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_net_openconnect/work/openconnect-2.26/Makefile Warning: reinplace s|@PREFIX@|/opt/local|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_net_openconnect/work/openconnect-2.26/Makefile }}} You've removed the patchfile (which is what put "@OPTFLAGS@" and "@PREFIX@" into the Makefile), but retained the reinplace that replaces those placeholders with other things. Either the patchfile needs to stay and continue to put those placeholders into the Makefile, or the reinplaces need to go. It's really preferable to use a patchfile than reinplaces where possible; where not possible, it's often preferable to use a combination -- patch in a placeholder, then reinplace that placeholder with the real value (as this port was doing before). Having a patchfile means that if upstream changes their source in the future and we either need to change or remove our patch, we'll have enough context in the patchfile to know what we were thinking before and know how we need to modify things now. Therefore, I'd like to see some of your changes reverted -- don't convert some of the patchfile's functionality to reinplaces. -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Comment(by ryandesign@…): Replying to [ticket:27809 Mathias.Laurin+macports@…]:
- add ''openmaintainer'' to the maintainers
r74869 -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 -----------------------------------------------+---------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: maintainer haspatch | Port: openconnect -----------------------------------------------+---------------------------- Comment(by ryandesign@…): Replying to [ticket:27809 Mathias.Laurin+macports@…]:
- ''livecheck'' actually works
r74873 -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27809: openconnect @2.25 updated to @2.26 ------------------------------------------------+--------------------------- Reporter: Mathias.Laurin+macports@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: maintainer haspatch Port: openconnect | ------------------------------------------------+--------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: In r74897 I just updated openconnect to 2.26, and added a post-destroot block to install some additional documentation files. I'll leave #27805 open and think about how we can best add an option to disable the use of gconf and gtk+. -- Ticket URL: <https://trac.macports.org/ticket/27809#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts