[MacPorts] #51481: libicns: update to 0.8.1
#51481: libicns: update to 0.8.1 -------------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: lib icns rsrc png | Port: libicns -------------------------------+-------------------------------- This version implement 1024x1024 support.[[BR]] https://sourceforge.net/p/icns/news/ [[BR]] [[BR]] I'm going to take maintainership of this port,[[BR]] but i've never done this before on MacPorts,[[BR]] so if i manage, it will surely take same time...[[BR]] MicheleVenturi-dardo82@gmail.com[[BR]] -- Ticket URL: <https://trac.macports.org/ticket/51481> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: lib icns rsrc png Port: libicns | ------------------------+-------------------------------- Comment (by dardo82@…): If i have done it right, it took less time than i feared... ^_^ -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: patch Port: libicns | ------------------------+-------------------------------- Changes (by khindenburg@…): * keywords: lib icns rsrc png => patch * cc: nomaintainer@… (removed) * version: 2.3.4 => Comment: OK thanks - not too bad a first attempt :-) - please try to not include whitespace/tab changes with actual changes - it makes it too hard to tell what's going on. Also, if we're using github now, we should use the 'PortGroup github 1.0' If you want to try again, go ahead - I may get around to helping you out in the next few days -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: patch Port: libicns | ------------------------+-------------------------------- Comment (by mf2k@…): @khindenburg: FYI we do not have a "patch" keyword. We do have a "haspatch" keyword however. -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: libicns | ------------------------+-------------------------------- Changes (by khindenburg@…): * keywords: patch => haspatch -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: libicns | ------------------------+-------------------------------- Comment (by dardo82@…): I am on GitHub as https://github.com/dardo82/. [[BR]] I also think that the patch is no more needed. [[BR]] So, what should I do now? [[BR]] -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: libicns | ------------------------+-------------------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => fixed Comment: Dardo, I went ahead and fix this r149039 r149040 - this was likely a hard example to start out with. Some notes: 1. no reason to use https://github.com/pornel/libicns/ since they haven't tagged any release. 2. You can see I first fix the whitespace issues and then committed the functional changes. You can read the guide for more info https://guide.macports.org/#project.contributing -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#51481: libicns: update to 0.8.1 ------------------------+-------------------------------- Reporter: dardo82@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: libicns | ------------------------+-------------------------------- Comment (by dardo82@…): As long as it's fixed, I'm happy with it. :-) [[BR]] Starting with simple things is not funny! :-P [[BR]] -- Ticket URL: <https://trac.macports.org/ticket/51481#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts