[MacPorts] #28668: checksum phase runs twice: to test and to print expected values
#28668: checksum phase runs twice: to test and to print expected values ------------------------------+--------------------------------------------- Reporter: snc@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.99 Keywords: | Port: ------------------------------+--------------------------------------------- Presently, checksums are run when testing the distfiles. They also get run again to produce the expected values that are displayed for verbose mode. Checksum phase should run once, and the output reused. `base/src/port1.0/portchecksum.tcl` Marking as enhancement for 2.0.0 as this could definitely be improved. -- Ticket URL: <https://trac.macports.org/ticket/28668> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: fixed | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * status: new => closed * resolution: => fixed Comment: r84985 -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: macports-tickets@… Type: enhancement | Status: reopened Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * status: closed => reopened * resolution: fixed => Comment: The fix is partially incorrect; it prints an invalid checksums line when there are multiple distfiles. -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: new Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * owner: macports-tickets@… => snc@… * status: reopened => new -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: assigned Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by snc@…): * status: new => assigned -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: assigned Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by snc@…): * cc: jmr@… (added) Comment: Hmm, I'm not seeing that behavior: {{{{ ---> Fetching xforms DEBUG: euid/egid changed to: 0/0 DEBUG: chowned /opt/local/var/macports/distfiles/xforms/1.0.93sp1_0 to macports DEBUG: euid/egid changed to: 509/515 DEBUG: Executing org.macports.fetch (xforms) DEBUG: Privilege de-escalation not attempted as not running as root. DEBUG: checksum phase started at Thu Dec 1 11:16:53 EST 2011 ---> Verifying checksum(s) for xforms DEBUG: Executing org.macports.checksum (xforms) ---> Checksumming xforms-1.0.93sp1.tar.gz DEBUG: Correct (md5) checksum for xforms-1.0.93sp1.tar.gz DEBUG: Correct (sha1) checksum for xforms-1.0.93sp1.tar.gz DEBUG: Correct (rmd160) checksum for xforms-1.0.93sp1.tar.gz ---> Checksumming xforms.html.tar.gz DEBUG: Correct (md5) checksum for xforms.html.tar.gz DEBUG: Correct (sha1) checksum for xforms.html.tar.gz DEBUG: Correct (rmd160) checksum for xforms.html.tar.gz ---> Checksumming xforms.pdf DEBUG: Correct (md5) checksum for xforms.pdf DEBUG: Correct (sha1) checksum for xforms.pdf DEBUG: Correct (rmd160) checksum for xforms.pdf }}} Do you have a specific port that I can test? -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: assigned Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Comment(by raimue@…): I can reproduce the problem mentioned by jmr. The problem is that the proposed checksums line in "The correct checksum line may be:" lists the names of the distfiles at the end. Or whatever it does, it is not valid... To reproduce the problem I replaced some of the checksums in the xforms port with an "x": {{{ ---> Verifying checksum(s) for xforms ---> Checksumming xforms-1.0.93sp1.tar.gz Error: Checksum (md5) mismatch for xforms-1.0.93sp1.tar.gz Portfile checksum: xforms-1.0.93sp1.tar.gz md5 x Distfile checksum: xforms-1.0.93sp1.tar.gz md5 68ed76216be9b09032e22736d95c8b3c Error: Checksum (sha1) mismatch for xforms-1.0.93sp1.tar.gz Portfile checksum: xforms-1.0.93sp1.tar.gz sha1 x Distfile checksum: xforms-1.0.93sp1.tar.gz sha1 a2c52f44ef4b20fc9002615f978eb49c79f63cd2 Error: Checksum (rmd160) mismatch for xforms-1.0.93sp1.tar.gz Portfile checksum: xforms-1.0.93sp1.tar.gz rmd160 x Distfile checksum: xforms-1.0.93sp1.tar.gz rmd160 cb094dbeb96b5adaa105e8f53ddbe5e452a0978e ---> Checksumming xforms.html.tar.gz ---> Checksumming xforms.pdf The correct checksum line may be: checksums md5 68ed76216be9b09032e22736d95c8b3c \ sha1 a2c52f44ef4b20fc9002615f978eb49c79f63cd2 \ rmd160 cb094dbeb96b5adaa105e8f53ddbe5e452a0978e \ md5 d89e634753ad349b281b072c84182aa6 \ sha1 7faa22e809dfec207931237bebd1572ff0a488c1 \ rmd160 1c2054aeead5031bff8fcdd5f38715247d0b62e7 \ md5 0080f2d50d76b8245bd63ee1d821b147 \ sha1 187e653fbae01f4652e2aa35a8f4806b4ae5abbc \ rmd160 e49a6f0d8485f72ef2ab93dba7e6f23b3132b9d9 \ xforms-1.0.93sp1.tar.gz \ xforms.html.tar.gz \ xforms.pdf }}} -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: assigned Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: | Keywords: Port: | -------------------------------+-------------------------------------------- Comment(by snc@…): Ah, thanks Raim. I couldn't see that before. -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: fixed | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by snc@…): * status: assigned => closed * resolution: => fixed Comment: Corrected in r87688. -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: fixed | Keywords: Port: | -------------------------------+-------------------------------------------- Comment(by snc@…): and r87689. -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts Future Component: base | Version: 1.9.99 Resolution: fixed | Keywords: Port: | -------------------------------+-------------------------------------------- Comment(by snc@…): and finally r87693. -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#28668: checksum phase runs twice: to test and to print expected values -------------------------------+-------------------------------------------- Reporter: snc@… | Owner: snc@… Type: enhancement | Status: closed Priority: Normal | Milestone: MacPorts 2.1.0 Component: base | Version: 1.9.99 Resolution: fixed | Keywords: Port: | -------------------------------+-------------------------------------------- Changes (by jmr@…): * milestone: MacPorts Future => MacPorts 2.1.0 -- Ticket URL: <https://trac.macports.org/ticket/28668#comment:> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts