[MacPorts] #38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default -------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Keywords: | Port: -------------------------+-------------------------------- This was originally brought up in comment:ticket:38279:6 by larryv. See [[source:tags/release_2_1_2/base/src/port1.0/portbuild.tcl#L63|how BSD Make does it]] for reference. -- Ticket URL: <https://trac.macports.org/ticket/38451> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Comment (by afb@…): The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux. Anyway, the path to the various makes are set when doing the ./configure so doing it in build is a tad late. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Comment (by larryv@…): Replying to [comment:1 afb@…]:
The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux.
I think the default Make on FreeBSD is BSD Make, while on Linux it’s [http://manpages.ubuntu.com/manpages/precise/en/man1/pmake.1.html installed as “pmake”].
Anyway, the path to the various makes are set when doing the ./configure so doing it in build is a tad late.
The code in `portbuild` is evaluated before any phases are performed. The `build.cmd` option just determines the command that is run as part of the build phase. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Changes (by larryv@…): * priority: Normal => Low Comment: I daresay most platforms have GNU Make by default. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Comment (by afb@…): Replying to [comment:2 larryv@…]:
The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux.
I think the default Make on FreeBSD is BSD Make, while on Linux it’s [http://manpages.ubuntu.com/manpages/precise/en/man1/pmake.1.html installed as “pmake”].
Forgot that the code isn't for other platforms, it's for installing bsdmake on Mac OS X when it is missing... (#33355) We could add a similar block for FreeBSD where gmake is "supposed" to be installed, but then removed or something. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Comment (by afb@…): Replying to [comment:3 larryv@…]:
I daresay most platforms have GNU Make by default.
Yes, especially with #12247 requiring it, in order to build base... {{{ bsdmake: fatal errors encountered -- cannot continue }}} -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: fixed | Keywords: Port: | --------------------------+-------------------------------- Changes (by afb@…): * status: new => closed * resolution: => fixed Comment: Fixed, r104303. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: fixed | Keywords: Port: | --------------------------+-------------------------------- Comment (by egall@…): Thanks! -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: fixed | Keywords: Port: | --------------------------+-------------------------------- Comment (by jmr@…): Neither gmake nor bsdmake should need an explicit depends_skip_archcheck, since they both set `installs_libs no`. -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#38451: RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Low | Milestone: Component: base | Version: 2.1.3 Resolution: fixed | Keywords: Port: | --------------------------+-------------------------------- Comment (by larryv@…): Replying to [comment:8 jmr@…]:
Neither gmake nor bsdmake should need an explicit depends_skip_archcheck, since they both set `installs_libs no`.
r104463 -- Ticket URL: <https://trac.macports.org/ticket/38451#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts