[MacPorts] #52706: emacs-app 25.1
#52706: emacs-app 25.1 -----------------------+-------------------------------- Reporter: isomarcte | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: emacs-app -----------------------+-------------------------------- I have upgraded the emacs-app port for emacs 25.1. This includes the porting the inline patch for emacs 25.1. I am a bit confused about why the inline variant is on by default, so in the attached file I disabled it by default. It seems, at least to me, to be surprising for the average user. Normally, I'd expect the default install of a port to be as close as possible to the upstream codebase, with variants adding customizations or extra features. This does seem to be what the macports guide itself recommends, https://guide.macports.org/#development.variants.default . Anyway, I hope it is helpful, let me know if I can change/fix anything. I have been running the 25.1 build locally for the past week using the given Portfile, off and on with the inline patch, and have thus far had no problems. -- Ticket URL: <https://trac.macports.org/ticket/52706> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app 25.1 ------------------------+-------------------------------- Reporter: isomarcte | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+-------------------------------- Changes (by isomarcte): * Attachment "Portfile-emacs-app.diff" added. Portfile patch -- Ticket URL: <https://trac.macports.org/ticket/52706> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app 25.1 ------------------------+-------------------------------- Reporter: isomarcte | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+-------------------------------- Changes (by isomarcte): * Attachment "patch-inline-25.1-20151017.diff" added. Updated inline patch -- Ticket URL: <https://trac.macports.org/ticket/52706> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app @24.5: update to 25.1 ------------------------+---------------------- Reporter: isomarcte | Owner: hum@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+---------------------- Changes (by larryv): * owner: macports-tickets@… => hum@… * status: new => assigned * version: 2.3.4 => * cc: hum@… (removed) Comment: Replying to [ticket:52706 isomarcte]:
I am a bit confused about why the inline variant is on by default, so in the attached file I disabled it by default. It seems, at least to me, to be surprising for the average user. Normally, I'd expect the default install of a port to be as close as possible to the upstream codebase, with variants adding customizations or extra features. This does seem to be what the macports guide itself recommends, https://guide.macports.org/#development.variants.default .
It’s up to the maintainer. We do not recommend or discourage adhering to the “upstream” configuration, although we do discourage overly fussy variants. Many maintainers choose to enable optional features without providing variants at all. Since you’re updating `version`, you must remove the `revision` line. -- Ticket URL: <https://trac.macports.org/ticket/52706#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app @24.5: update to 25.1 ------------------------+---------------------- Reporter: isomarcte | Owner: hum@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+---------------------- Changes (by isomarcte): * Attachment "Portfile-emacs-app.diff" added. Updated Portfile -- Ticket URL: <https://trac.macports.org/ticket/52706> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app @24.5: update to 25.1 ------------------------+---------------------- Reporter: isomarcte | Owner: hum@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+---------------------- Comment (by isomarcte): Oops. Thanks for catching that! Updated. -- Ticket URL: <https://trac.macports.org/ticket/52706#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#52706: emacs-app @24.5: update to 25.1 ------------------------+---------------------- Reporter: isomarcte | Owner: hum@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: emacs-app | ------------------------+---------------------- Comment (by isomarcte): Looks like I also put the wrong date on the inline patch...definitely is not 2015... I don't see any way to rename a file, just replace them. So I am leaving it as is. -- Ticket URL: <https://trac.macports.org/ticket/52706#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts