[MacPorts] #37352: Fixes for #38606 and #36807
#37352: Fixes for #38606 and #36807 --------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: torsocks --------------------------+-------------------------------- Updated Portfile for torsocks package, includes fixes for #38606 and #38607. -- Ticket URL: <https://trac.macports.org/ticket/37352> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) * keywords: => haspatch Old description:
Updated Portfile for torsocks package, includes fixes for #38606 and #38607.
New description: Updated Portfile for torsocks package, includes fixes for #36806 and #36807. -- Comment: Thank you but this patch has a few problems: * it mixes whitespace and functional changes * it introduces your name into the maintainers line, which should only contain (obfuscated) email addresses * it changes "OS X" (which is the correct name of the OS) to "Mac OSX" * it adds a "dist_subdir" line which is unnecessary unless a stealth update has occurred, which I assume it hasn't since you haven't changed the checksums * it removes the license line * it adds "--prefix=${prefix}" to configure.args which is unnecessary because MacPorts automatically puts that into configure.pre_args * it changes master_sites from the simple and recommended googlecode to a more verbose URL * it adds an unnecessary "# end of file." comment -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Comment (by ryandesign@…): * Further to the whitespace changes, you've replaced spaces, which are our preferred indentation style, with tabs. We should however make some whitespace adjustment, because our preferred style (which the portfile claims—via its modeline—to comply with) is to indent at multiples of four spaces. * Also, since these changes change the files that are installed, the portfile's revision should be increased. -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Comment (by sami.laine@…): Replacement diff with expanded tabs attached. -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Comment (by sami.laine@…): A brand new Portfile attached incorporating most of the changes mentioned. -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Comment (by sami.laine@…): A diff attached also, just in case a whole Portfile is not likeable. -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#37352: torsocks: Fixes for #36806 and #36807 ---------------------------+-------------------------------- Reporter: sami.laine@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: torsocks | ---------------------------+-------------------------------- Changes (by mf2k@…): * status: new => closed * version: 2.1.2 => * resolution: => fixed Comment: Thanks and sorry for the long delay. Committed in r124314 with the following changes: - Did not rename OS X to "Mac OS X" because that is not the correct name. - Did not remove the rmd160 checksum. - Set the revision to 1 since 0 is the default value. - Whitespace adjustments per Macports standard. -- Ticket URL: <https://trac.macports.org/ticket/37352#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts