[MacPorts] #27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed -----------------------------------+---------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: gsed | Port: smartmontools -----------------------------------+---------------------------------------- update-smart-drivedb script doesn't work properly with BSD sed since it contains ERE. Here is a patch to fix this problem. -- Ticket URL: <https://trac.macports.org/ticket/27330> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed -----------------------------------+---------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: gsed | Port: smartmontools -----------------------------------+---------------------------------------- Comment(by jmr@…): Couldn't you just use `sed -E`? -- Ticket URL: <https://trac.macports.org/ticket/27330#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed -----------------------------------+---------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: gsed | Port: smartmontools -----------------------------------+---------------------------------------- Comment(by takanori@…): I know TIMTOWTDI. ;-) In this case, using GNU sed is more reliable than using BSD sed with -E option, I think. -- Ticket URL: <https://trac.macports.org/ticket/27330#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed -----------------------------------+---------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: gsed | Port: smartmontools -----------------------------------+---------------------------------------- Comment(by Christian.Franke@…): Please test update-smart-drivedb-sed.patch with BSD sed if possible. Then I could fix this upstream ([http://sourceforge.net/apps/trac/smartmontools/ticket/126 Smartmontools Ticket #126]). -- Ticket URL: <https://trac.macports.org/ticket/27330#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed ------------------------------------+--------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: gsed Port: smartmontools | ------------------------------------+--------------------------------------- Changes (by takanori@…): * status: new => closed * resolution: => fixed Comment: Your patch worked perfectly. (tested on Mac OS X 10.6.5/x86_64 and 10.5.8/ppc) Committed in r73687 - Thanks! -- Ticket URL: <https://trac.macports.org/ticket/27330#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#27330: smartmontools @5.40_0: update-smart-drivedb script requires GNU sed ------------------------------------+--------------------------------------- Reporter: takanori@… | Owner: toby@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: gsed Port: smartmontools | ------------------------------------+--------------------------------------- Comment(by Christian.Franke@…): Thanks for testing. Committed upstream in [http://sourceforge.net/apps/trac/smartmontools/changeset/3214 r3214]. -- Ticket URL: <https://trac.macports.org/ticket/27330#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts