[MacPorts] #35003: pv @1.2.0 request to update port to the latest version
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Request to update port pv to the latest release (currently version 1.3.1).[[BR]] A difference report of the Portfile is attached.[[BR]] Note: The existing patch stat64.diff is successfully applied with fuzz 1 for file src/pv/loop.c, if this is regarded as an error or unwanted a new patch file should be created. -- Ticket URL: <https://trac.macports.org/ticket/35003> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Comment(by meissnem@…): nonstop.server@ -- are you interested in taking on the maintainer role? I rarely use pv anymore, so I'd rather it be in the hands of someone who cares... -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Comment(by nonstop.server@…): Replying to [comment:1 meissnem@…]: Hi meissnem,[[BR]] Thank you for your proposition however I'm not sure how much time I'll be able to spend on macports in the long run, so I would like to keep it the way it is.[[BR]] I don't mind providing patches where and when I can without actually being the official maintainer. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Comment(by ryandesign@…): The attached diff contains both whitespace and functional changes. Please supply diffs that do only one or the other. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Comment(by nonstop.server@…): Replying to [comment:3 ryandesign@…]: The original diff has been split up in two diffs for whitespace and functional changes respectively.[[BR]] Please see the newly attached difference reports. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Comment(by meissnem@…): These new patches look good to me. I do not have commit privileges, so ryandesign@ if you're still listening and would be willing to commit it that would be great. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version --------------------------------------+------------------------------------- Reporter: nonstop.server@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Keywords: haspatch | Port: pv --------------------------------------+------------------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: Thank you. But note that if we're going to make whitespace changes, then we want the port's fixed whitespace to conform to our style guidelines, which are 4 spaces per indent; that's what the modeline you're adding says too. I've committed the corrected whitespace and formatting changes in r95761. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version ---------------------------------------+------------------------------------ Reporter: nonstop.server@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: haspatch Port: pv | ---------------------------------------+------------------------------------ Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: As for the functional changes, note that we want to use the rmd160 / sha256 checksum pair these days. There don't appear to be any downloads for this at Google Code (anymore?) so I removed that address from the master_sites. 1.3.4 is available in the mean time. I refreshed the stat64 patch. I committed the functional changes in r95762. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#35003: pv @1.2.0 request to update port to the latest version ---------------------------------------+------------------------------------ Reporter: nonstop.server@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.1 Resolution: fixed | Keywords: haspatch Port: pv | ---------------------------------------+------------------------------------ Comment(by nonstop.server@…): Replying to [comment:7 ryandesign@…]: Thank you for the upgrade and all the corrections.[[BR]] I'll leave out the md5 checksum next time and keep white-spaces at four spaces in future patches. -- Ticket URL: <https://trac.macports.org/ticket/35003#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts