[MacPorts] #38397: new port: bowtie2
#38397: new port: bowtie2 ------------------------+-------------------------------- Reporter: sean@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Keywords: | Port: ------------------------+-------------------------------- -- Ticket URL: <https://trac.macports.org/ticket/38397> MacPorts <http://www.macports.org/> Ports system for OS X
#38397: new port: bowtie2 -------------------------+-------------------------------- Reporter: sean@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by egall@…): `port -v lint --nitpick` reports the following warnings: {{{ Warning: Line 2 is missing RCS tag ($Id$) Warning: no license set }}} Also I'd add some manual line wrapping to the `long_description` there. And also generally `openmaintainer` goes last in the maintainers list. But those are just nitpicks; otherwise it looks good. -- Ticket URL: <https://trac.macports.org/ticket/38397#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#38397: new port: bowtie2 -------------------------+-------------------------------- Reporter: sean@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: bowtie2 | -------------------------+-------------------------------- Changes (by ryandesign@…): * port: => bowtie2 Comment: The destroot can be simplified to just: {{{ destroot { xinstall -W ${worksrcpath} bowtie2 bowtie2-align bowtie2-build bowtie2-inspect ${destroot}${prefix}/bin } }}} `eval` is not necessary because you're not evaluating any globs. 0755 is the default mode. xinstall can install multiple files at once. Using `use_configure no` means you need to manually ensure you're UsingTheRightCompiler and `-arch` flags and add a universal variant if possible—unless this port doesn't build architecture-specific software, in which case you need `supported_archs noarch`. When writing sourceforge master_sites you have to be sure to [wiki:howto/AvoidRedirects avoid redirects]. -- Ticket URL: <https://trac.macports.org/ticket/38397#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#38397: new port: bowtie2 -------------------------+-------------------------------- Reporter: sean@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: bowtie2 | -------------------------+-------------------------------- Comment (by larryv@…): If all you want to do is specify that the distfile has a different name than the default, don’t set `distfiles`; set `distname` instead, and leave off the extension. `use_zip` sets the correct extension for you. You’ll probably have to set `worksrcdir` back to `${name}-${version}`. Does the build seriously not support `make install`? `xinstall` supports installing several files at once; you should do this instead of calling `xinstall` separately for each file. See the `portfile(7)` man page. -- Ticket URL: <https://trac.macports.org/ticket/38397#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#38397: new port: bowtie2 -------------------------+-------------------------------- Reporter: sean@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: bowtie2 | -------------------------+-------------------------------- Comment (by sean@…): Updated, thanks for the comments. I'll hold off on the others until this one is correct. -- Ticket URL: <https://trac.macports.org/ticket/38397#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts