#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by hsivank@…): This is a rewrite of the original Wireshark Portfile.[[BR]] It is possible to switch between Qt4, Qt5, Gtk2, Gtk3 backend.[[BR]] The configure step is done by cmake. (As Qt, it will be the future of Wireshark...)[[BR]] For now I use svn to fetch source. (There are some problems with official 1.11.0 tar : bugs, files missing ...) -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by hsivank@…): Thanks for your comments.[[BR]] What about the qt5 variant ? Macports does not support Qt5 yet. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by hsivank@…): ok i will remove it -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by ryandesign@…): Looks like I was mistaken about the no_gui variant; it has already existed in the wireshark-devel port for years. But it's confusing then that it's not in the wireshark port too. I wish the wireshark and wireshark-devel ports were maintained by the same maintainer(s) and did not differ so wildly from one another. A port and its -devel counterpart should typically only differ in the version number and any necessary changes to make that version build properly. You don't need to set CMAKE_INSTALL_NAME_DIR; the cmake portgroup already sets it for you. You just need to append to configure.args rather than overwriting it. You also still need to append to, rather than overwriting, depends_build. There are a lot of variants in this port. Why has a zlib variant been added, for example? Under what circumstances would a user want to disable zlib support? Variants are typically added when an optional a dependency takes a lot of time or disk space to install, or when the user must choose amongst multiple options. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by ryandesign@…): Replying to [comment:10 hsivank@…]:

Currently Wireshark is evolving a lot, so I think it is the good moment to remove old variant .. if not you will have *no_gui* variant for 10 years again in macports ;-)[[BR]]

Yes. wireshark-devel also still has a "no_ssl" variant which should be restructured to be an "ssl" variant. wireshark still has variants no_adns, no_geoip, no_gnutls, no_ipv6, no_libgcrypt, no_libsmi, no_lua, no_rtp, no_ssl, no_x11; fixes to restructure these should be brought over to the wireshark port from the wireshark-devel port.

If i remove CMAKE_INSTALL_NAME_DIR, RPATH is removed during destroot phase. (osx 10.7) [[BR]]

I don't see why it would matter whether the portfile adds the option or the portgroup adds the option. Either way, the option should get added.

Variants reflect option provided by wireshark : http://anonsvn.wireshark.org/viewvc/trunk/CMakeOptions.txt?revision=52513&vi...

A portfile usually should not offer variants for every option supported by the build system. Rather, the maintainer should select the options that make sense and program them into the portfile, and offer a very small number of variants if necessary to support unusual options or ones with heavy dependencies.

Yes there is a big diff between wireshark and wireshark-devel. But cmake is the way to go. When qtshark will be released as stable, The Portfile will be ready for Wireshark's Portfile.

I understand that wireshark 1.11 has switched to cmake, so that difference between wireshark and wireshark-devel is expected. The other differences, including differing variants and differing whitespace, are not. In this case, the variants and whitespace of the wireshark-devel port are more conformant with current MacPorts best practices, so the wireshark port should adopt them. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by mojca@…): Are there any news about this update? There is version 1.11.2 out already and there should be no problem to fetch the sources from `tar.bz2` (if there are, they also have git access available now in addition to svn). Personally I would vote for providing the `qt` interface only. I don't see any particular need for `gtk`, it will only cause headaches and one will have to fix problems related to it without any benefit. It only makes sense to support `gtk` if Qt isn't working properly yet. I'm not saying that the port shouldn't provide it, only that it's not necessary to have it. You can keep support for GTK if you find it useful. And yes, I also suggest to simply turn all the relevant features on without a special variant for that unless that feature isn't working, causes problems or requires too many dependencies. Can you please submit a new `Portfile` (or diff) for 1.11.2 and taking the latest comments into account? (Ryan explicitly asked for a diff. This usually makes a lot of sense, but in this particular case where basically everything other than description is changed, plain `Portfile` works much better, at least for me. I'm not advocating using one or another, only explaining that in cases like this one the diffs are hardly more informative.) I agree with the proposal to leave the old `wireshark` port intact (= not to worry about it) and simply rename this port once the version 1.12.0 gets released. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by mojca@…): One question (out of many): `./configure --help` says {{{ --with-broken-python[=DIR] }}} Doesn't that mean that the option name also needs to be adapted? I get: {{{ configure: WARNING: unrecognized options: --without-pcre, --without-python }}} Let's forget for a moment that `cmake`-based installation isn't ready yet (I didn't even try it). What about providing the option to enable `Qt`? I built it with {{{ --without-gtk2 \ --without-gtk3 \ --with-qt \ --with-osx-integration }}} and it compiled fine at least. I downloaded their Qt binary for mac and it also seems to work just fine. I didn't play much with the port from MacPorts though. Anyway, I can apply your patch as is (without Qt if you didn't test it yet), but it would make sense to figure out what to do with the python switch (whether it needs to be renamed or not). -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by macsforever2000@…): I applied your patch and ran lint. Here are the results: {{{ $ port lint --nitpick ---> Verifying Portfile for wireshark-devel Warning: Variant gnutls does not have a description Warning: Variant libgcrypt does not have a description Warning: Variant ipv6 does not have a description Warning: Variant lua does not have a description Warning: Variant no_ssl does not have a description Warning: Variant libsmi does not have a description Warning: Dependency port:gtk2 specified multiple times in depends_lib ---> 0 errors and 7 warnings found. }}} The last one needs to be fixed. Indeed gtk2 is always a dependency and the default gtk2 adds it again. Adding descriptions to all variants would be very helpful too. Finally, the {{{no_ssl}}} variant name needs to be changed to {{{ssl}}} and thus do the opposite. Is there a good reason for it? Maybe it should simply be removed. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:18> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by mojca@…): Based on [https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7b15672... this commit] I wonder if wireshark actually works better with Qt 5 on Mac. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:20> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by hsivank@…): Replying to [comment:18 macsforever2000@…]:

I applied your patch and ran lint. Here are the results: The last one needs to be fixed. Indeed gtk2 is always a dependency and the default gtk2 adds it again. Adding descriptions to all variants would be very helpful too. Finally, the {{{no_ssl}}} variant name needs to be changed to {{{ssl}}} and thus do the opposite. Is there a good reason for it? Maybe it should simply be removed.

Thanks for your remarks. I will try to make a proper patch quickly -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:22> MacPorts <http://www.macports.org/> Ports system for OS X

#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by ryandesign@…): qt5 is in MacPorts now. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:24> MacPorts <http://www.macports.org/> Ports system for OS X