[MacPorts] #29303: gant is noarch
#29303: gant is noarch -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: breskeby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: gant -------------------------------------+-------------------------------------- gant doesn't install any architecture-specific files, so should say `supported_archs noarch` and the `revision` should be increased. Further changes you could consider making to gant include removing the `distname`, `worksrcdir` and `use_bzip2 no` lines (those are the defaults); switching from using `ui_msg` in a post-activate block to using `notes`; and removing the `workTarget` variable and the one place it's used, unless it serves some purpose I'm not seeing. -- Ticket URL: <https://trac.macports.org/ticket/29303> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29303: gant fixes: noarch, remove unnecessary lines, use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: breskeby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: gant -------------------------------------+-------------------------------------- Comment(by ryandesign@…): Not in the attached patch, but you should also remove `extract.post_args | gnutar -x` from the `platform darwin` section: it does nothing (MacPorts overwrites `extract.post_args` when the extract phase begins) and isn't correct (this distfile is a zip file, not a tar file). -- Ticket URL: <https://trac.macports.org/ticket/29303#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29303: gant fixes: noarch, remove unnecessary lines, use notes -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: breskeby@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: gant -------------------------------------+-------------------------------------- Comment(by ryandesign@…): You added "supported_archs noarch" in r78331; I've attached a revised patch with the remaining changes. -- Ticket URL: <https://trac.macports.org/ticket/29303#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29303: gant fixes: noarch, remove unnecessary lines, use notes ---------------------------+-------------------------- Reporter: ryandesign@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: | Keywords: haspatch Port: gant | ---------------------------+-------------------------- Changes (by mf2k@…): * owner: breskeby@… => ryandesign@… Comment: breskeby has retired. See #44732. @ryan: Please commit your changes. -- Ticket URL: <https://trac.macports.org/ticket/29303#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts