#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by g5pw@…): Are you interested in maintaining the port? I see that you listed both nomaintainer and openmaintainer. Nomaintainer means that the package is not maintained by anyone, openmaintainer means it is maintained by someone (the email of the maintainer must precede it). Also, don't use commas in the maintainer line. If you fetch from github, perhaps you can use the github PortGroup to simplify the portfile a bit. Is there a reason you disable fortran when building? We have a [[PortfileRecipes#fortran|recipe]] to help select the correct fortran compiler, maybe you can use that. Also, please don't use {{{system}}} words to move files, use the macports {{{move}}} word. Remember that system has a {{{-W}}} option to set the working directory, so you don't have to {{{cd}}} in. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by mf2k@…): Some more comments - this is not a complete review: - Add sha256 and rmd160 checksums and remove the sha1 and md5 ones unless provided upstream. - Since you are using portgroups, and those often add dependencies, you need to replace {{{depends_lib}}} with {{{depends_lib-append}}} and {{{depends_build}}} with {{{depends_build-append}}} to not overwrite them. - The python portgroup is normally only for python modules. However, if this port requires python to build, that is ok. However, you must choose only one python version. That should be 2.7 since that is the default in Macports. - You do not need to remove FORTRAN support in Macports. Please consider keeping it since many ports have this. But use the compilers portgroup which actually replaces the FORTRAN recipe. Unfortunately, that is not documented so look at a port like hdf4 or julia. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by mf2k@…): Also, unless I'm missing something, there is no point in using the github portgroup if you are downloading source from sourceforge. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by mf2k@…): More comments: - We don't allow variants to change the version. Instead you should use a subport. See the gnuradio port for an example. It has a gnuradio-devel subport in the same Portfile. - You need to obfuscate your email address: i.e. thomasfiala.de:macports - You do not need the following structure: {{{ post-install { notes-append }}} Just replace it with {{{notes}}} and do not have it inside a {{{post- install}}} block. - Remove the blank {{{pre-destroot}}} block -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by macports@…): Thanks again, it should be a lot cleaner now as well. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by mf2k@…): A few more things: - You are using the default $distname and so that line should be deleted. - You reference "$prefix" and "$destroot" in a few places. Those should be "${prefix}" and "${destroot}". I don't know enough TCL to know the difference, but all other ports do it this way. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: Port: cantera | -------------------------+-------------------------------- Comment (by larryv@…): Replying to [comment:14 macports@…]:

I assume that the curly braces only make a difference if you use compounds like ${python.version}. Also, $prefix without curly braces is often used in the MacPorts Guide.

Braces are required if the name of the scalar variable contains any character that isn’t a letter, digit, underscore, or Tcl namespace separator (two or more consecutive colons). More to the point, our current style is to always use the braces in Portfiles, for consistency. Some of us also think it’s more readable. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X

#44719: Add port cantera -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: cantera | -------------------------+-------------------------------- Changes (by mf2k@…): * status: new => closed * version: 2.3.1 => * resolution: => fixed Comment: Thanks for your patience. r125605. -- Ticket URL: <https://trac.macports.org/ticket/44719#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X