#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Changes (by larryv@…): * keywords: => haspatch * version: 2.2.1 => -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Comment (by mail@…): Ryan, thanks for the feedback. ad 1) I just deleted every line I was not sure of, so the $ld$ line was deleted too (Is there any documentation about what this line does? I found none in the guide, but maybe I overlooked it...). I changed that in my second patch. ad 2) I just forgot to delete the maintainer before patching, this was just for me to know that I made the changes. Also changed. ad 3) I just deleted the lines, cos I could not get it to build with it. I did not have time to dig into that, I was hoping someone with more knowledge might come along and help... ;-) -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Comment (by Peter.Danecek@…): I at a quick look at your patch, here some considerations: - Looking quick at PyPI, I would assume there no support for Python 2.4 and 2.5 anymore, so you might want to check this; - Consider also if you really want to support Python 3.1 and maybe even 3.2 could be already left out; - I learned it is better, to have the livecheck active only for the main port and deactivate it for the subports; -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Comment (by mail@…): Version5 of the patch has a working post-destroot. The names of some files had changed, that was what has broken my first tries. -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Comment (by Peter.Danecek@…): PyPI usually provides `md5` checksum, so I usually put them in my Portfiles as well, `sha1` should probably be replaced. BTW: checking for the `md5` checksum I realised, the package was updated recently to 3.6, you may want to consider this update. The homepage is redirected to https protocol as well, I personally would change this as well. But I am not sure if this is required by some guideline. -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Changes (by g5pw@…): * status: new => closed * resolution: => fixed Comment: Hello! I was the one updating the port and didn't notice there already was an open ticket for its update. The changes above are implemented in r117770. I took the liberty of setting the homepage to the one indicated in setup.py. ojkastl, would you like to take maintainership of this port? -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X

#42593: py*-keyring @0.6.2_0: update to 3.5 -------------------------+-------------------------------- Reporter: mail@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: py-keyring | -------------------------+-------------------------------- Comment (by Peter.Danecek@…): Replying to [comment:13 mail@…]:

Replying to [comment:12 g5pw@…]:

...

ojkastl, would you like to take maintainership of this port?

I'm glad, someone with more knowledge has taken over, so, no, thanks! ;-)

Just go ahead and give it a try! As maintainer you look after updates or fixes occasionally. That's how it starts all ;-). You will not have commit rights immediately, this way your patches are are review and if you have some doubts just ask the developer list. -- Ticket URL: <https://trac.macports.org/ticket/42593#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X