[MacPorts] #48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig
#48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig ----------------------+------------------------ Reporter: larryv@… | Owner: tessarek@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: tmux-devel ----------------------+------------------------ The configure phase fails if `pkgconfig` is not installed or visible. This affects our Buildbot buildslaves, and you can observe it for yourself with trace mode: {{{ % sudo port -dt configure tmux-devel [...] DEBUG: Executing command line: cd "/opt/local/var/macports/build /_Users_larryv_Projects_MacPorts_git-svn_trunk_dports_sysutils_tmux/tmux- devel/work/tmux-83a70172a4a12ee9fa069b381172ddbf75c92ad1" && ./autogen.sh configure.ac:17: installing 'etc/compile' configure.ac:9: installing 'etc/config.guess' configure.ac:9: installing 'etc/config.sub' configure.ac:7: installing 'etc/install-sh' configure.ac:7: installing 'etc/missing' Makefile.am: installing 'etc/depcomp' configure.ac:112: error: possibly undefined macro: AC_SEARCH_LIBS If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /opt/local/bin/autoconf failed with exit status: 1 autoreconf failed Command failed: cd "/opt/local/var/macports/build /_Users_larryv_Projects_MacPorts_git-svn_trunk_dports_sysutils_tmux/tmux- devel/work/tmux-83a70172a4a12ee9fa069b381172ddbf75c92ad1" && ./autogen.sh Exit code: 1 }}} The error message is misleading; the problem is actually at line 115, [https://github.com/tmux/tmux/blob/48a46e066ed2836cf8b58da65a2d730011702ee5/c... where configure.ac tries to use PKG_CHECK_MODULES], which is defined in `pkgconfig`’s pkg.m4 file. I’ve attached two patches. One makes the build use autogen.sh, as upstream recommends. It also patches autogen.sh to invoke Autotools verbosely, to aid debugging. The other actually adds the dependency on `pkgconfig`. -- Ticket URL: <https://trac.macports.org/ticket/48015> MacPorts <https://www.macports.org/> Ports system for OS X
#48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig -------------------------+------------------------ Reporter: larryv@… | Owner: tessarek@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: tmux-devel | -------------------------+------------------------ Comment (by tessarek@…): Hi Larry, Thanks for the patches. Look good to me. I missed this since I do have pkgconfig installed. Also, I would not have thought it were needed in the first place. Do we really need the verbose output? No more debugging needed anyway at the moment. It might help in the future, although I don't think that this should be done in userland. -- Ticket URL: <https://trac.macports.org/ticket/48015#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig -------------------------+------------------------ Reporter: larryv@… | Owner: tessarek@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: tmux-devel | -------------------------+------------------------ Comment (by larryv@…): Replying to [comment:1 tessarek@…]:
Do we really need the verbose output?
Not really, if you don’t want it. Admittedly, `aclocal --verbose` is incredibly talkative. -- Ticket URL: <https://trac.macports.org/ticket/48015#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig -------------------------+------------------------ Reporter: larryv@… | Owner: tessarek@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: tmux-devel | -------------------------+------------------------ Comment (by tessarek@…): I love debugging output, but I'd rather use it locally when needed. -- Ticket URL: <https://trac.macports.org/ticket/48015#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48015: tmux-devel @20150604-83a7017_0: missing build dependency on pkgconfig -------------------------+------------------------ Reporter: larryv@… | Owner: tessarek@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: haspatch Port: tmux-devel | -------------------------+------------------------ Changes (by larryv@…): * status: new => closed * resolution: => fixed Comment: We prefer verbose output in general because it makes user-submitted logs more useful. But Autotools are generally pretty well-behaved (at least, when we use them), so it’s less necessary there. Anyway, r137408 and r137409. -- Ticket URL: <https://trac.macports.org/ticket/48015#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts