#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+------------------------- Reporter: ionic@… | Owner: macports- Type: defect | tickets@… Priority: Normal | Status: new Component: ports | Milestone: Resolution: | Version: Port: py-SRPAstro py-matplotlib py-scipy | Keywords: haspatch -------------------------------------------------+------------------------- Comment (by ionic@…): Revbumped ports to account for dependency change. -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+------------------------- Reporter: ionic@… | Owner: macports- Type: defect | tickets@… Priority: Normal | Status: new Component: ports | Milestone: Resolution: | Version: Port: py-SRPAstro py-matplotlib py-scipy | Keywords: haspatch -------------------------------------------------+------------------------- Comment (by petr@…): I just looked though the code. It specifies pil as an requirement, so I would argue that at least **formally** it depends on PIL. So this should be better addressed upstream. {{{ sudo grep -i pil * -r [...] SRPAstro.egg-info/requires.txt:pil setup.py: install_requires=['scipy', 'astlib>=0.4', 'pil', 'matplotlib', 'atpy', }}} -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+------------------------- Reporter: ionic@… | Owner: macports- Type: defect | tickets@… Priority: Normal | Status: new Component: ports | Milestone: Resolution: | Version: Port: py-SRPAstro py-matplotlib py-scipy | Keywords: haspatch -------------------------------------------------+------------------------- Comment (by petr@…): For `py-matplotlib` there seems to be no strict requirement for PIL neither. Import are found only in `lib/matplotlib/backend_bases.py`, `lib/matplotlib/image.py` and `lib/matplotlib/tests/test_image.py`, but the absence of PIL is handled smoothly. All other occurrences are only in documentation or examples. So the missing dependence on PIL seems to be intentional. From `lib/matplotlib/backend_bases.py`: {{{ try: from PIL import Image _has_pil = True except ImportError: _has_pil = False _backend_d = {} }}} From `lib/matplotlib/image.py` {{{ def pilread(fname): """try to load the image with PIL or return None""" try: from PIL import Image except ImportError: return None }}} From `lib/matplotlib/tests/test_image.py`: {{{ try: from PIL import Image HAS_PIL = True except ImportError: HAS_PIL = False }}} -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+---------------------- Reporter: ionic@… | Owner: petr@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: py-SRPAstro py-matplotlib py-scipy | -------------------------------------------------+---------------------- Comment (by petr@…): After reviewing this it looks like the dependencies of these ports are currently handled correctly. The PIL dependency should stay with `py-SRPAstro`. If you still believe this port should not depend on `PIL`, please report upstream. -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X

#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+---------------------- Reporter: ionic@… | Owner: petr@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: invalid | Keywords: haspatch Port: py-SRPAstro py-matplotlib py-scipy | -------------------------------------------------+---------------------- Changes (by petr@…): * status: assigned => closed * resolution: => invalid -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X

#44308: py-SRPAstro: switch PIL/Pillow dependency to py-matplotlib and py-scipy. -------------------------------------------------+---------------------- Reporter: ionic@… | Owner: petr@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: invalid | Keywords: haspatch Port: py-SRPAstro py-matplotlib py-scipy | -------------------------------------------------+---------------------- Comment (by petr@…): I really believe the current approach is appropriate. Intentionally neither `matplotlib` nor `scipy` declare a dependency on `PIL`, probably for some good reason (I could imagine to avoid any of the fuss with PIL), so MP should neither. Adding a variant, does not provide any advantage, it just complicates the situation while installing exactly the same set of files. You cannot guaranty the right variant is installed anyway, but you can do this for `PIL`/`Pillow`. The extra functionally provided seems not to be expected by users or software (no tickets), and if you need it you just have to install `PIL` or `Pillow`, or just uninstall any time you want. So I see no problem here. `SRPAstro` does exactly this, it expects this extra functionality provided by PIL, so it declares the dependency on it, and only this can guaranty it is around, with a variant you cannot be sure. -- Ticket URL: <https://trac.macports.org/ticket/44308#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X