[MacPorts] #52750: /changeset/:commitid/:repo is very slow for changes that do not exist
#52750: /changeset/:commitid/:repo is very slow for changes that do not exist ----------------------------+--------------------- Reporter: neverpanic | Owner: admin@… Type: defect | Status: new Priority: High | Milestone: Component: server/hosting | Version: 2.3.4 Keywords: | Port: ----------------------------+--------------------- Crawlers seem to be accessing our copy of Trac and try to access changesets from the GitHub changeset module that no longer exist. One such example is - https://github.com/macports/macports- ports/commit/671c5d2885aad2df28c916e68f98a143e06bdf48 vs. - https://github.com/macports/macports- ports/commit/ac26746154eb37fa1413e57f9f082bc2e37b9f22 Only the latter is still relevant, the former is still available at GitHub from a previous push, though. We should try find find out how to get rid of it. One possibility to avoid the slowdown would be to just avoid validating whether a commit ID is valid in Trac and redirect to GitHub right-away. We need to figure out if anybody in Trac uses short commit IDs (if nobody does, we can drop the validation). Here are IDs to test that: - [671c5d28/macports-ports] - [ac267461/macports-ports] -- Ticket URL: <https://trac.macports.org/ticket/52750> MacPorts <https://www.macports.org/> Ports system for OS X
#52750: /changeset/:commitid/:repo is very slow for changes that do not exist -----------------------------+--------------------- Reporter: neverpanic | Owner: admin@… Type: defect | Status: new Priority: High | Milestone: Component: server/hosting | Version: 2.3.4 Resolution: | Keywords: Port: | -----------------------------+--------------------- Comment (by neverpanic): Problem seems to be that checking whether a commit is in a repository is very slow with PyGit, due to shelling out to the git command line binary, see https://github.com/edgewall/trac/blob/1.0-stable/tracopt/versioncontrol/git/... -- Ticket URL: <https://trac.macports.org/ticket/52750#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#52750: /changeset/:commitid/:repo is very slow for changes that do not exist -----------------------------+--------------------- Reporter: neverpanic | Owner: admin@… Type: defect | Status: closed Priority: High | Milestone: Component: server/hosting | Version: 2.3.4 Resolution: worksforme | Keywords: Port: | -----------------------------+--------------------- Changes (by neverpanic): * status: new => closed * resolution: => worksforme Comment: Cannot reproduce, seems fast at the moment. -- Ticket URL: <https://trac.macports.org/ticket/52750#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts