[MacPorts] #29093: changing $worksrcdir break the build when using git.fetch or hg.fetch
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: base | Version: 1.9.2 Keywords: | Port: --------------------------------------+------------------------------------- git/hg fetch the source code directly into $worksrcpath. If your port need to change the $worksrcdir (e.g. the source to be built is in a subdirectory) the build fails because $worksrcpath is defined as $workpath/$worksrcdir and the source is now in the wrong directory. See the attached portfile for an example that demostrates this behavior. The suggested patch uses $workpath/$distname as the location for git/hg fetch. -- Ticket URL: <https://trac.macports.org/ticket/29093> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: base | Version: 1.9.2 Keywords: | Port: --------------------------------------+------------------------------------- Comment(by ryandesign@…): Note that you don't need to change worksrcdir in your portfile. You could instead change configure.dir and/or build.dir, for example. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: base | Version: 1.9.2 Keywords: | Port: --------------------------------------+------------------------------------- Comment(by ciserlohn@…): Replying to [comment:1 ryandesign@…]:
Note that you don't need to change worksrcdir in your portfile. You could instead change configure.dir and/or build.dir, for example.
I know, and for this portfile this is already fixed (see #28799). I used this as an example because I encountered this bug while developing the portfile. The problem is there anyway. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Changes (by raimue@…): * keywords: => haspatch * milestone: => MacPorts 2.0.0 -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: I don't think there's any need to wait until 2.0.0; I don't think changing this should break any existing ports. At the same time, we can fix `fetch.type svn` to have the same behavior; it's always bugged me that it behaved differently. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Changes (by raimue@…): * cc: raimue@… (added) Comment: I thought we do not want to do any 1.x release anymore? Other changes on trunk are currently targeting 2.0. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Comment(by ryandesign@…): Oh, in that case whatever. :) -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: ryandesign@… Type: defect | Status: assigned Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (removed) * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: This needs to be fixed differently. `hgfetch` and `gitfetch` need to be rewritten to use `command_exec` (like `bzrfetch`, `cvzfetch` and `svnfetch` do) instead of `system`. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: ryandesign@… Type: defect | Status: assigned Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Comment(by ciserlohn@…): Replying to [comment:7 ryandesign@…]:
This needs to be fixed differently. `hgfetch` and `gitfetch` need to be rewritten to use `command_exec` (like `bzrfetch`, `cvzfetch` and `svnfetch` do) instead of `system`.
Please have a look at the new patch. It uses the 'command_exec' for git.fetch and fetches the source to '$workpath/$distname' like the first patch. Feedback and suggestions are welcome. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29093: changing $worksrcdir break the build when using git.fetch or hg.fetch --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: ryandesign@… Type: defect | Status: assigned Priority: Normal | Milestone: MacPorts 2.0.0 Component: base | Version: 1.9.2 Keywords: haspatch | Port: --------------------------------------+------------------------------------- Comment(by ciserlohn@…): Replying to [comment:7 ryandesign@…]:
This needs to be fixed differently. `hgfetch` and `gitfetch` need to be rewritten to use `command_exec` (like `bzrfetch`, `cvzfetch` and `svnfetch` do) instead of `system`.
Please have a look at the latest patch. 'command_exec' is used for both git.fetch and hg.fetch. The source will also be fetched to '$workpath/$distname' like the first patch does. Feedback and suggestions are welcome. -- Ticket URL: <https://trac.macports.org/ticket/29093#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts