[MacPorts] #52231: libphonenumber-cpp Problem with Long values in test
#52231: libphonenumber-cpp Problem with Long values in test --------------------------+-------------------------------- Reporter: arboz@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: leopard i386 | Port: libphonenumber-cpp --------------------------+-------------------------------- There has been the recurring issue of use of Long values in the test I seem to remember that it was fixed upstream, but as of last version upgrade it appeared again I constructed a patch to show the changes however I suppose it is better to send upstream -- Ticket URL: <https://trac.macports.org/ticket/52231> MacPorts <https://www.macports.org/> Ports system for macOS
#52231: libphonenumber-cpp Problem with Long values in test ---------------------------------+----------------------------------- Reporter: arboz@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: leopard i386 haspatch Port: libphonenumber-cpp | ---------------------------------+----------------------------------- Changes (by ryandesign@…): * keywords: leopard i386 => leopard i386 haspatch * owner: macports-tickets@… => devans@… * cc: devans@…, openmaintainer@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/52231#comment:1> MacPorts <https://www.macports.org/> Ports system for macOS
#52231: libphonenumber-cpp Problem with Long values in test ---------------------------------+----------------------------------- Reporter: arboz@… | Owner: devans@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: leopard i386 haspatch Port: libphonenumber-cpp | ---------------------------------+----------------------------------- Changes (by devans@…): * status: new => assigned Comment: Thanks for the report and patch. Yes, I suggest you report this upstream so it gets fixed there and add a pointer to the resulting issue/PR to this ticket so we can track it. In the meantime I'll apply your fix to the current version. -- Ticket URL: <https://trac.macports.org/ticket/52231#comment:2> MacPorts <https://www.macports.org/> Ports system for macOS
#52231: libphonenumber-cpp Problem with Long values in test ---------------------------------+----------------------------------- Reporter: arboz@… | Owner: devans@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: leopard i386 haspatch Port: libphonenumber-cpp | ---------------------------------+----------------------------------- Changes (by devans@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r152625. Looks like this was a case of new test code that wasn't careful about declaring large longs. Previously existing code declares these properly. -- Ticket URL: <https://trac.macports.org/ticket/52231#comment:3> MacPorts <https://www.macports.org/> Ports system for macOS
#52231: libphonenumber-cpp Problem with Long values in test ---------------------------------+----------------------------------- Reporter: arboz@… | Owner: devans@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: leopard i386 haspatch Port: libphonenumber-cpp | ---------------------------------+----------------------------------- Comment (by arboz@…): Thanks, I put a comment with a copy of the patch on the GITHUB Issues https://github.com/googlei18n/libphonenumber/issues/1334 number 1334 -- Ticket URL: <https://trac.macports.org/ticket/52231#comment:4> MacPorts <https://www.macports.org/> Ports system for macOS
participants (1)
-
MacPorts