#29445: jslint port ------------------------------+--------------------------------------------- Reporter: tael67@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: | Port: jslint ------------------------------+--------------------------------------------- Comment(by tael67@…): Replying to [comment:1 ryandesign@…]:

Some observations:

* This is different from the existing javascript-lint port, yes? * Pin the fetch down to a specific revision (git.branch...) * Does this port install architecture-specific files? (supported_archs...) * You cannot run "js" in pre-fetch; the dependencies might not have been built by then (they will have been built by pre-configure) * Don't put a slash before ${prefix} (${prefix} already starts with a slash) * Don't put "/opt/local" in the patchfile (use "@PREFIX@")

*Yes, they are too different (although similar) software. *OK, sorry. *No, it is entirely in JavaScript. I will test what you suggested and upload an updated portfile. -- Ticket URL: <https://trac.macports.org/ticket/29445#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#29445: jslint port -------------------------------+-------------------------------------------- Reporter: tael67@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: Port: jslint | -------------------------------+-------------------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r78580 with these changes: * fixed whitespace (tabs to spaces, indent to multiple of 4 spaces, as the modeline says) * added "supported_archs noarch" since there are no architecture-specific files installed * do the reinplace of @PREFIX@ to ${prefix} in the patch phase * instead of "use_configure no" and a pre-configure block, just write a configure block * specify absolute path to js, just in case * use "return -code error" (not "error") to error out * tweaked wording of error message * switched spidermonkey depends_run to depends_lib, since it is needed at build time (namely in the check in the configure phase) On my system, "`js -e "new File();"`" crashes with a segmentation fault, so the port tells me I need to install spidermonkey with the +fileobject variant, though I already have. Here's hoping other users don't see that. -- Ticket URL: <https://trac.macports.org/ticket/29445#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS