[MacPorts] #42845: daemon @0.6.4 fails build on mavericks
#42845: daemon @0.6.4 fails build on mavericks ---------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: daemon ---------------------+-------------------------------- main.log attached -- Ticket URL: <https://trac.macports.org/ticket/42845> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: daemon | ----------------------+-------------------------------- Comment (by mtb19@…): Same problem on brew: https://github.com/Homebrew/homebrew/issues/25455 No fix there (yet) either. -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: daemon | ----------------------+-------------------------------- Comment (by mtb19@…): After minimal investigation, it seems mavericks defines its own strlcpy and strlcat (as macros). libslack (included by daemon) has redundant definitions as C functions in slack/str.[hc]. Their implementations are guarded by #ifndef HAVE_STRLC(AT|PY) statements in str.c, but their prototype definitions are not similarly guarded in str.h. Also, while HAVE_STRLC(AT|PY) are properly set to 1 in config.h for Darwin, config.h is not included by daemon.c before daemon.c includes slack/str.h, so even if the str.h definitions were guarded, compiling daemon.c would fail to exclude them. Attached is a patch that addresses both of these problems. -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: daemon | ----------------------+-------------------------------- Comment (by mtb19@…): I managed a successful build via ports by moving the attached patch file to <[PREFIX]/var/macports/sources/rsync.macports.org/release/tarballs/ports/sysutils/daemon/files/strlcpy_strlcat.patch> and adding the following lines to the Portfile: {{{ patchfiles strlcpy_strlcat.patch patch.pre_args -p1 }}} I am Portfile NOOB, but I can imitate without understanding with the best of them. :o) FYI, I have not tested this on anything other than mavericks, so I don't know if it will still build in snow leopard, lion, etc. -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: daemon | ----------------------+-------------------------------- Comment (by mtb19@…): Looks like the patch was good enough for brew (wink, wink, nudge, nudge): https://github.com/Homebrew/homebrew/issues/25455 -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: daemon | ----------------------+-------------------------------- Comment (by khindenburg@…): Thanks for the research and patches - I have it working here and will commit it - need to check if it will build on older systems. -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#42845: daemon @0.6.4 fails build on mavericks ----------------------+-------------------------------- Reporter: mtb19@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: daemon | ----------------------+-------------------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => fixed Comment: r121184 -- Ticket URL: <https://trac.macports.org/ticket/42845#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts