#24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: blair@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: ice-cpp, ice-java, ice-python, ice-python25, ice-python26 -------------------------------------+-------------------------------------- Comment(by ryandesign@…): ---- Next, [attachment:distfiles.diff simplify the distfiles]. I'd remove setting distfiles and remove the distfile name from inside the checksums definition. You're setting distname, and you only have one distfile, so that's enough. -- Ticket URL: <http://trac.macports.org/ticket/24904#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: blair@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: ice-cpp, ice-java, ice-python, ice-python25, ice-python26 -------------------------------------+-------------------------------------- Comment(by ryandesign@…): ---- I'd let MacPorts handle the [attachment:patch.diff patch phase]. In ice- cpp and ice-java you override the patch phase and do the patching manually, but it seems to work fine if you just let MacPorts do it. This patch also includes a refresh of ice-cpp's patchfile so it applies without fuzz. -- Ticket URL: <http://trac.macports.org/ticket/24904#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS

#24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: blair@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: ice-cpp, ice-java, ice-python, ice-python25, ice-python26 -------------------------------------+-------------------------------------- Comment(by ryandesign@…): ---- Ok, here's a bigger one to [attachment:worksrcpath.diff make more use of worksrcpath and build.dir]. I see a lot of "${workpath}/Ice-${version}" in these portfiles, and this could be simplified to "${worksrcpath}". And there's several places where you're dealing with a specific subdirectory of ${worksrcpath} -- "cpp" in the ice-cpp port, "java" in the java port, "py" in the python ports -- and this could be further abstracted out into the build.dir variable. This will additionally save you from needing to set test.dir or destroot.dir, since both of those variables' default values is ${build.dir}. And this lets you eliminate some other variables (ice-java and cppdir) which end up being the same as ${build.dir}. -- Ticket URL: <http://trac.macports.org/ticket/24904#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS

#24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: blair@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.8.2 Keywords: | Port: ice-cpp, ice-java, ice-python, ice-python25, ice-python26 -------------------------------------+-------------------------------------- Comment(by ryandesign@…): ---- I'd [attachment:variants.diff change the variants] so all the code relating to the variants is inside the variant declarations. Some disagree, but I find this clearer. The Guide in fact advocates the opposite (advocates doing it the way you already do it in these ports), and this used to be required in older versions of MacPorts, but hasn't been for years, and I no longer recommend it. See #18359. -- Ticket URL: <http://trac.macports.org/ticket/24904#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS